Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h

Issue 2979413002: Refactor composing report blocks for rtcp Sender/Receiver reports (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 14 matching lines...) Expand all
25 public: 25 public:
26 static constexpr uint8_t kPacketType = 201; 26 static constexpr uint8_t kPacketType = 201;
27 ReceiverReport(); 27 ReceiverReport();
28 ~ReceiverReport() override; 28 ~ReceiverReport() override;
29 29
30 // Parse assumes header is already parsed and validated. 30 // Parse assumes header is already parsed and validated.
31 bool Parse(const CommonHeader& packet); 31 bool Parse(const CommonHeader& packet);
32 32
33 void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; } 33 void SetSenderSsrc(uint32_t ssrc) { sender_ssrc_ = ssrc; }
34 bool AddReportBlock(const ReportBlock& block); 34 bool AddReportBlock(const ReportBlock& block);
35 bool SetReportBlocks(std::vector<ReportBlock> blocks);
35 36
36 uint32_t sender_ssrc() const { return sender_ssrc_; } 37 uint32_t sender_ssrc() const { return sender_ssrc_; }
37 const std::vector<ReportBlock>& report_blocks() const { 38 const std::vector<ReportBlock>& report_blocks() const {
38 return report_blocks_; 39 return report_blocks_;
39 } 40 }
40 41
41 size_t BlockLength() const override; 42 size_t BlockLength() const override;
42 43
43 bool Create(uint8_t* packet, 44 bool Create(uint8_t* packet,
44 size_t* index, 45 size_t* index,
45 size_t max_length, 46 size_t max_length,
46 RtcpPacket::PacketReadyCallback* callback) const override; 47 RtcpPacket::PacketReadyCallback* callback) const override;
47 48
48 private: 49 private:
49 static const size_t kRrBaseLength = 4; 50 static const size_t kRrBaseLength = 4;
50 static const size_t kMaxNumberOfReportBlocks = 0x1F; 51 static const size_t kMaxNumberOfReportBlocks = 0x1F;
51 52
52 uint32_t sender_ssrc_; 53 uint32_t sender_ssrc_;
53 std::vector<ReportBlock> report_blocks_; 54 std::vector<ReportBlock> report_blocks_;
54 }; 55 };
55 56
56 } // namespace rtcp 57 } // namespace rtcp
57 } // namespace webrtc 58 } // namespace webrtc
58 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RECEIVER_REPORT_H_ 59 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_RECEIVER_REPORT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698