Enable tracing on rtcstats_integrationtest.cc

webrtc/pc/rtcstats_integrationtest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <set>
 #include <vector>
 
 #include "webrtc/api/audio_codecs/builtin_audio_decoder_factory.h"
 #include "webrtc/api/audio_codecs/builtin_audio_encoder_factory.h"
 #include "webrtc/api/datachannelinterface.h"
 #include "webrtc/api/peerconnectioninterface.h"
 #include "webrtc/api/stats/rtcstats_objects.h"
 #include "webrtc/api/stats/rtcstatsreport.h"
 #include "webrtc/pc/test/peerconnectiontestwrapper.h"
 #include "webrtc/pc/test/rtcstatsobtainer.h"
 #include "webrtc/rtc_base/checks.h"
+#include "webrtc/rtc_base/event_tracer.h"
 #include "webrtc/rtc_base/gunit.h"
 #include "webrtc/rtc_base/refcountedobject.h"
 #include "webrtc/rtc_base/scoped_ref_ptr.h"
 #include "webrtc/rtc_base/virtualsocketserver.h"
 
 namespace webrtc {
 
 namespace {
 
 const int64_t kGetStatsTimeoutMs = 10000;
+const unsigned char* kWebRTCStatsCategory =
+    reinterpret_cast<const unsigned char*>("webrtc_stats");

[tommi, 2017/07/18 12:22:54]

static_cast, however the cast shouldn't be here.  instead do:

const char kWebRTCStatsCategory[] = "webrtc_stats";

and change the function (which doesn't need to be static since it's in an
anonymous namespace):

const unsigned char* GetCategoryEnabledHandler(const char* name) {
  return static_cast<const unsigned char*>(&kWebRTCStatsCategory[0]);
}

You could also declare the constant as a static inside the scope of the
function.

[ehmaldonado_webrtc, 2017/07/18 12:36:19]

I get:

error: static_cast from 'const char *' to 'const unsigned char *' is not allowed

+
+static const unsigned char* GetCategoryEnabledHandler(const char* name) {
+  return kWebRTCStatsCategory;
+}
+
+static void AddTraceEventHandler(char phase,
+                                 const unsigned char* category_enabled,
+                                 const char* name,
+                                 unsigned long long id,
+                                 int num_args,
+                                 const char** arg_names,
+                                 const unsigned char* arg_types,
+                                 const unsigned long long* arg_values,
+                                 unsigned char flags) {
+  // Do nothing
+}
 
 class RTCStatsIntegrationTest : public testing::Test {
  public:
   RTCStatsIntegrationTest()
       : network_thread_(new rtc::Thread(&virtual_socket_server_)),
         worker_thread_(rtc::Thread::Create()) {
+    SetupEventTracer(&GetCategoryEnabledHandler, &AddTraceEventHandler);
+
     RTC_CHECK(network_thread_->Start());
     RTC_CHECK(worker_thread_->Start());
 
     caller_ = new rtc::RefCountedObject<PeerConnectionTestWrapper>(
         "caller", network_thread_.get(), worker_thread_.get());
     callee_ = new rtc::RefCountedObject<PeerConnectionTestWrapper>(
         "callee", network_thread_.get(), worker_thread_.get());
   }
 
   void StartCall() {
@@ skipping 601 matching lines @@
   caller_ = nullptr;
   // Any pending stats requests should have completed in the act of destroying
   // the peer connection.
   EXPECT_TRUE(stats_obtainer->report());
 }
 #endif  // HAVE_SCTP
 
 }  // namespace
 
 }  // namespace webrtc