Add texture support to HardwareVideoDecoder.

webrtc/sdk/android/api/org/webrtc/HardwareVideoDecoderFactory.java

 /*
  *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 package org.webrtc;
 
 import static org.webrtc.MediaCodecUtils.EXYNOS_PREFIX;
 import static org.webrtc.MediaCodecUtils.INTEL_PREFIX;
 import static org.webrtc.MediaCodecUtils.NVIDIA_PREFIX;
 import static org.webrtc.MediaCodecUtils.QCOM_PREFIX;
 
 import android.media.MediaCodec;
 import android.media.MediaCodecInfo;
 import android.media.MediaCodecInfo.CodecCapabilities;
 import android.media.MediaCodecList;
 import android.os.Build;
 
 /** Factory for Android hardware VideoDecoders. */
 @SuppressWarnings("deprecation") // API level 16 requires use of deprecated methods.
 public class HardwareVideoDecoderFactory implements VideoDecoderFactory {
   private static final String TAG = "HardwareVideoDecoderFactory";
 
+  private final SurfaceTextureHelper helper;
+
+  /** Creates a HardwareVideoDecoderFactory that does not use surface textures. */
+  @Deprecated // Not removed yet to avoid breaking callers.  Remove once Duo is ready.

[sakal, 2017/07/17 13:44:56]

I don't think we should reference internal projects directly in open source
code.

[mellem, 2017/07/17 21:57:15]

Done.

+  public HardwareVideoDecoderFactory() {
+    this(null);
+  }
+
+  /**
+   * Creates a HardwareVideoDecoderFactory that supports surface texture rendering using the given
+   * SurfaceTextureHelper.  SurfaceTextureHelper may be null.  If it is null, then surface support
+   * is disabled.
+   */
+  public HardwareVideoDecoderFactory(SurfaceTextureHelper helper) {
+    this.helper = helper;
+  }
+
   @Override
   public VideoDecoder createDecoder(String codecType) {

[pthatcher1, 2017/07/11 18:30:24]

Would it make more sense to pass the helper into createDecoder so different
decoders can uses textures or not?  

[mellem, 2017/07/11 20:51:41]

I don't think we want to change the factory interface.  The existing factory has
a separate method to set it.  But it's set once as part of HW acceleration
options and never changed:

https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/android/src/jni/v...

If you like a separate method better than a constructor argument, I can do that.
 I just thought it made more sense as a constructor argument, given the current
usage (set once and never changed).

     VideoCodecType type = VideoCodecType.valueOf(codecType);
     MediaCodecInfo info = findCodecForType(type);
 
     if (info == null) {
       return null; // No support for this codec type.
     }
 
     CodecCapabilities capabilities = info.getCapabilitiesForType(type.mimeType());
     return new HardwareVideoDecoder(info.getName(), type,
-        MediaCodecUtils.selectColorFormat(MediaCodecUtils.DECODER_COLOR_FORMATS, capabilities));
+        MediaCodecUtils.selectColorFormat(MediaCodecUtils.DECODER_COLOR_FORMATS, capabilities),
+        helper);
   }
 
   private MediaCodecInfo findCodecForType(VideoCodecType type) {
     // HW decoding is not supported on builds before KITKAT.
     if (Build.VERSION.SDK_INT < Build.VERSION_CODES.KITKAT) {
       return null;
     }
 
     for (int i = 0; i < MediaCodecList.getCodecCount(); ++i) {
       MediaCodecInfo info = null;
@@ skipping 40 matching lines @@
         return name.startsWith(QCOM_PREFIX) || name.startsWith(EXYNOS_PREFIX);
       case H264:
         // QCOM, Intel, and Exynos supported for H264.
         return name.startsWith(QCOM_PREFIX) || name.startsWith(INTEL_PREFIX)
             || name.startsWith(EXYNOS_PREFIX);
       default:
         return false;
     }
   }
 }