Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2557)

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm

Issue 2977213002: Reland of Injectable Obj-C video codecs (Closed)
Patch Set: Hopefully fix no-video bug in duo Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
index d3f5ef9a93300eb5ad6b722e0e71c54adf95614b..3674d1869d85d87f7d719c689d97dd153de68487 100644
--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm
@@ -537,9 +537,9 @@ int H264VideoToolboxEncoder::Release() {
// Need to reset so that the session is invalidated and won't use the
// callback anymore. Do not remove callback until the session is invalidated
// since async encoder callbacks can occur until invalidation.
- int ret = ResetCompressionSession();
+ DestroyCompressionSession();
jtt_webrtc 2017/07/20 02:33:20 This is not the problem. See ObjCVideoEncoder::~Ob
kthelgason 2017/07/20 11:33:51 Agreed. I still think we should make this change.
jtt_webrtc 2017/07/20 17:55:59 I'm not sure what implications this will have beca
callback_ = nullptr;
- return ret;
+ return WEBRTC_VIDEO_CODEC_OK;
}
int H264VideoToolboxEncoder::ResetCompressionSession() {

Powered by Google App Engine
This is Rietveld 408576698