Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2976363002: Decoupling rtc_base from apple specific code [without cyclic deps] (Closed)

Created:
3 years, 5 months ago by mbonadei
Modified:
3 years, 4 months ago
Reviewers:
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

First step of decoupling rtc_base from apple specific code Bug=webrtc:7743

Patch Set 1 #

Patch Set 2 : trying to fix ios64_sim_ios9_dbg #

Patch Set 3 : trying to fix ios_dbg #

Patch Set 4 : fixing some compilation problems #

Patch Set 5 : moving thread_darwin.mm out of rtc_base #

Patch Set 6 : fixing network_tester_server #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -10 lines) Patch
M webrtc/BUILD.gn View 1 2 3 4 6 chunks +20 lines, -1 line 0 comments Download
M webrtc/audio/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/common_audio/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/examples/BUILD.gn View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 3 4 15 chunks +47 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 chunks +7 lines, -1 line 0 comments Download
M webrtc/ortc/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/pc/BUILD.gn View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/rtc_base/BUILD.gn View 1 2 3 4 3 chunks +13 lines, -5 lines 0 comments Download
M webrtc/rtc_tools/BUILD.gn View 1 2 3 4 4 chunks +13 lines, -0 lines 0 comments Download
M webrtc/rtc_tools/network_tester/BUILD.gn View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/stats/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 1 2 3 4 3 chunks +9 lines, -0 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
mbonadei
3 years, 4 months ago (2017-08-11 12:14:26 UTC) #3 
Closing this CL because we decided to allow cyclic dependencies in
this specific use case.

Powered by Google App Engine
This is Rietveld 408576698