Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: webrtc/video/video_quality_test.h

Issue 2974903002: Add rtpdump and rtc log functionality to screenshare_loopback and video_loopback (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_loopback.cc ('k') | webrtc/video/video_quality_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_quality_test.h
diff --git a/webrtc/video/video_quality_test.h b/webrtc/video/video_quality_test.h
index 2008c7348c5e7becbeb461b2dd8a649a5948fbfb..3bb5cd282eac87994e4c8b2a7062c8b069038205 100644
--- a/webrtc/video/video_quality_test.h
+++ b/webrtc/video/video_quality_test.h
@@ -34,6 +34,7 @@ class VideoQualityTest : public test::CallTest {
struct CallConfig {
bool send_side_bwe;
Call::Config::BitrateConfig call_bitrate_config;
+ int num_thumbnails;
} call;
struct Video {
bool enabled;
@@ -50,7 +51,6 @@ class VideoQualityTest : public test::CallTest {
int min_transmit_bps;
bool ulpfec;
bool flexfec;
- std::string encoded_frame_base_path;
std::string clip_name; // "Generator" to generate frames instead.
size_t capture_device_index;
} video;
@@ -74,7 +74,6 @@ class VideoQualityTest : public test::CallTest {
std::string graph_title;
} analyzer;
FakeNetworkPipe::Config pipe;
- bool logs;
struct SS { // Spatial scalability.
std::vector<VideoStream> streams; // If empty, one stream is assumed.
size_t selected_stream;
@@ -85,7 +84,12 @@ class VideoQualityTest : public test::CallTest {
// If set, default parameters will be used instead of |streams|.
bool infer_streams;
} ss;
- int num_thumbnails;
+ struct Logging {
+ bool logs;
+ std::string rtc_event_log_name;
+ std::string rtp_dump_name;
+ std::string encoded_frame_base_path;
+ } logging;
};
VideoQualityTest();
« no previous file with comments | « webrtc/video/video_loopback.cc ('k') | webrtc/video/video_quality_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698