Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: webrtc/modules/audio_processing/aec3/residual_echo_estimator_unittest.cc

Issue 2974583004: Transparency improvements in the echo canceller 3 (Closed)
Patch Set: Corrected wrong echo estimate vector in unittest Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/aec3/residual_echo_estimator_unittest.cc
diff --git a/webrtc/modules/audio_processing/aec3/residual_echo_estimator_unittest.cc b/webrtc/modules/audio_processing/aec3/residual_echo_estimator_unittest.cc
index b28cf517976336608eac07c0b38852f8764a2dac..b448c4df43ef275503af89e3341cfc1acf16bb82 100644
--- a/webrtc/modules/audio_processing/aec3/residual_echo_estimator_unittest.cc
+++ b/webrtc/modules/audio_processing/aec3/residual_echo_estimator_unittest.cc
@@ -52,6 +52,7 @@ TEST(ResidualEchoEstimator, BasicTest) {
Random random_generator(42U);
FftData X;
std::array<float, kBlockSize> x_old;
+ std::array<float, kBlockSize> s;
Aec3Fft fft;
for (auto& H2_k : H2) {
@@ -60,6 +61,11 @@ TEST(ResidualEchoEstimator, BasicTest) {
H2[2].fill(10.f);
H2[2][0] = 0.1f;
+ std::array<float, kAdaptiveFilterTimeDomainLength> h;
+ h.fill(0.f);
+
+ s.fill(100.f);
+
constexpr float kLevel = 10.f;
E2_shadow.fill(kLevel);
E2_main.fill(kLevel);
@@ -74,8 +80,8 @@ TEST(ResidualEchoEstimator, BasicTest) {
render_buffer.Insert(x);
aec_state.HandleEchoPathChange(echo_path_variability);
- aec_state.Update(H2, rtc::Optional<size_t>(2), render_buffer, E2_main, Y2,
- x[0], false);
+ aec_state.Update(H2, h, rtc::Optional<size_t>(2), render_buffer, E2_main,
+ Y2, x[0], s, false);
estimator.Estimate(true, aec_state, render_buffer, S2_linear, Y2, &R2);
}
« no previous file with comments | « webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc ('k') | webrtc/modules/audio_processing/aec3/subtractor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698