Protected streams report RTP messages directly to the FlexFec streams

webrtc/video/video_quality_test.cc

Index: webrtc/video/video_quality_test.cc
diff --git a/webrtc/video/video_quality_test.cc b/webrtc/video/video_quality_test.cc
index 1719595d3a7e2fa3094ffae43918d8b7306a92ed..c0fe45ae88c140afae5755ffbfaf9890fd8d3087 100644
--- a/webrtc/video/video_quality_test.cc
+++ b/webrtc/video/video_quality_test.cc
@@ -2046,6 +2046,11 @@ void VideoQualityTest::RunWithRenderers(const Params& params) {
     video_send_stream_->Stop();
     for (FlexfecReceiveStream* flexfec_receive_stream :
          flexfec_receive_streams_) {
+      for (VideoReceiveStream* video_receive_stream : video_receive_streams_) {
+        // TODO(eladalon): !!! Discuss with reviewers - do we perhaps want
+        // something else to be in charge of removing the secondary sinks?

[danilchap, 2017/07/24 09:03:46]

what are the alternatives to choose from?

[eladalon, 2017/07/24 13:15:48]

I found it unclear that DestroyFlexfecReceiveStream() is called from a different
class than CreateFlexfecReceiveStream(), but I don't think that's in this CL's
scope to fix. Other than that, it's probably better to RemoveSecondarySink()
explicitly, rather than have it triggered by DestroyFlexfecReceiveStream(). I'm
removing the TODO.

+        video_receive_stream->RemoveSecondarySink(flexfec_receive_stream);
+      }
       flexfec_receive_stream->Stop();
       receiver_call_->DestroyFlexfecReceiveStream(flexfec_receive_stream);
     }