Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Unified Diff: webrtc/call/flexfec_receive_stream_impl.h

Issue 2974453002: Protected streams report RTP messages directly to the FlexFec streams (Closed)
Patch Set: Rebase and rephrase comment. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/flexfec_receive_stream_impl.h
diff --git a/webrtc/call/flexfec_receive_stream_impl.h b/webrtc/call/flexfec_receive_stream_impl.h
index e4eb68342e13c36df2423023d2e209c1f025d061..90246e328841e30534cb435148e9bda1356e4741 100644
--- a/webrtc/call/flexfec_receive_stream_impl.h
+++ b/webrtc/call/flexfec_receive_stream_impl.h
@@ -29,8 +29,7 @@ class RtpRtcp;
class RtpStreamReceiverControllerInterface;
class RtpStreamReceiverInterface;
-class FlexfecReceiveStreamImpl : public FlexfecReceiveStream,
- public RtpPacketSinkInterface {
+class FlexfecReceiveStreamImpl : public FlexfecReceiveStream {
public:
FlexfecReceiveStreamImpl(
RtpStreamReceiverControllerInterface* receiver_controller,
@@ -54,6 +53,8 @@ class FlexfecReceiveStreamImpl : public FlexfecReceiveStream,
// Config.
const Config config_;
bool started_ GUARDED_BY(crit_);
+ // TODO(eladalon): This critical section, which only protects started_,
+ // is odd. We should probably just use an atomic-bool.
rtc::CriticalSection crit_;
// Erasure code interfacing.

Powered by Google App Engine
This is Rietveld 408576698