Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: build/android/pylib/symbols/stack_symbolizer.py

Issue 2974163002: Fix the stack script issue when symbolizing tombstones. (Closed)
Patch Set: add todo and crbug; revert changes for intentional crash test case Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/symbols/stack_symbolizer.py
diff --git a/build/android/pylib/symbols/stack_symbolizer.py b/build/android/pylib/symbols/stack_symbolizer.py
new file mode 100644
index 0000000000000000000000000000000000000000..8ddf1f34fb18bfdb095ec4c444522ace29146f75
--- /dev/null
+++ b/build/android/pylib/symbols/stack_symbolizer.py
@@ -0,0 +1,102 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import logging
+import os
+import re
+import shutil
+import tempfile
+import zipfile
+
+from devil.utils import cmd_helper
+from pylib import constants
+
+_STACK_TOOL = os.path.join(os.path.dirname(__file__), '..', '..', '..', '..',
+ 'third_party', 'android_platform', 'development',
+ 'scripts', 'stack')
+ABI_REG = re.compile('ABI: \'(.+?)\'')
+
+
+def _DeviceAbiToArch(device_abi):
+ # The order of this list is significant to find the more specific match
+ # (e.g., arm64) before the less specific (e.g., arm).
+ arches = ['arm64', 'arm', 'x86_64', 'x86_64', 'x86', 'mips']
+ for arch in arches:
+ if arch in device_abi:
+ return arch
+ raise RuntimeError('Unknown device ABI: %s' % device_abi)
+
+
+class Symbolizer(object):
+ """A helper class to symbolize stack."""
+
+ def __init__(self, apk_under_test=None,
+ enable_relocation_packing=None):
+ self._apk_under_test = apk_under_test
+ self._enable_relocation_packing = enable_relocation_packing
+ self._libs_dir = None
+ self._apk_libs = []
+ self._has_unzipped = False
+
+
+ def __del__(self):
+ if self._libs_dir:
+ logging.warning('Please call stack_symbolizer\'s'
+ ' CleanUp method before it goes out of scope.')
+ self.CleanUp()
+
+
+ def CleanUp(self):
+ """Clean up the temporary directory of apk libs."""
+ if self._libs_dir:
+ shutil.rmtree(self._libs_dir)
+ self._libs_dir = None
+
+
+ def UnzipAPKIfNecessary(self):
+ """Unzip apk if packed relocation is enabled."""
+ if (self._has_unzipped
+ or not self._enable_relocation_packing
+ or not self._apk_under_test):
+ return
+ self._libs_dir = tempfile.mkdtemp()
+ with zipfile.ZipFile(self._apk_under_test) as z:
+ for name in z.namelist():
+ if name.endswith('.so'):
+ self._apk_libs.append(z.extract(name, self._libs_dir))
+
+ self._has_unzipped = True
+
+
+ def ExtractAndResolveNativeStackTraces(self, data_to_symbolize,
+ device_abi, include_stack=True):
+ """Run the stack tool for given input.
+
+ Args:
+ data_to_symbolize: a list of strings to symbolize.
+ include_stack: boolean whether to include stack data in output.
+ device_abi: the default ABI of the device which generated the tombstone.
+
+ Yields:
+ A string for each line of resolved stack output.
+ """
+ self.UnzipAPKIfNecessary()
+ arch = _DeviceAbiToArch(device_abi)
+ if not arch:
+ logging.warning('No device_abi can be found.')
+ return
+
+ cmd = [_STACK_TOOL, '--arch', arch, '--output-directory',
+ constants.GetOutDirectory(), '--more-info']
+ if self._enable_relocation_packing and self._apk_libs:
+ for apk_lib in self._apk_libs:
+ cmd.extend(['--packed-lib', apk_lib])
+ with tempfile.NamedTemporaryFile() as f:
+ f.write('\n'.join(data_to_symbolize))
+ f.flush()
+ _, output = cmd_helper.GetCmdStatusAndOutput(cmd + [f.name])
+ for line in output.splitlines():
+ if not include_stack and 'Stack Data:' in line:
+ break
+ yield line
« no previous file with comments | « build/android/pylib/local/device/local_device_instrumentation_test_run.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698