Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Side by Side Diff: tools/mb/mb.py

Issue 2974163002: Fix the stack script issue when symbolizing tombstones. (Closed)
Patch Set: add todo and crbug; revert changes for intentional crash test case Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2015 The Chromium Authors. All rights reserved. 2 # Copyright 2015 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """MB - the Meta-Build wrapper around GYP and GN 6 """MB - the Meta-Build wrapper around GYP and GN
7 7
8 MB is a wrapper script for GYP and GN that can be used to generate build files 8 MB is a wrapper script for GYP and GN that can be used to generate build files
9 for sets of canned configurations and analyze them. 9 for sets of canned configurations and analyze them.
10 """ 10 """
(...skipping 868 matching lines...) Expand 10 before | Expand all | Expand 10 after
879 runtime_deps_path = self.ToAbsPath(build_dir, r) 879 runtime_deps_path = self.ToAbsPath(build_dir, r)
880 if self.Exists(runtime_deps_path): 880 if self.Exists(runtime_deps_path):
881 break 881 break
882 else: 882 else:
883 raise MBErr('did not generate any of %s' % 883 raise MBErr('did not generate any of %s' %
884 ', '.join(runtime_deps_targets)) 884 ', '.join(runtime_deps_targets))
885 885
886 command, extra_files = self.GetIsolateCommand(target, vals) 886 command, extra_files = self.GetIsolateCommand(target, vals)
887 887
888 runtime_deps = self.ReadFile(runtime_deps_path).splitlines() 888 runtime_deps = self.ReadFile(runtime_deps_path).splitlines()
889 if android:
890 # TODO(hzl): Rewrite the following lib.unstripped logic.
891 # crbug.com/749283
892 unstripped_libs = []
893 for f in runtime_deps:
894 if f.endswith('.so'):
895 if os.path.isfile(self.PathJoin(self.ToAbsPath(build_dir),
896 'lib.unstripped',
897 os.path.basename(f))):
898 unstripped_libs.append('lib.unstripped/%s' % os.path.basename(f))
899 runtime_deps.extend(unstripped_libs)
889 900
890 self.WriteIsolateFiles(build_dir, command, target, runtime_deps, 901 self.WriteIsolateFiles(build_dir, command, target, runtime_deps,
891 extra_files) 902 extra_files)
892 903
893 return 0 904 return 0
894 905
895 def RunGNIsolate(self, vals): 906 def RunGNIsolate(self, vals):
896 target = self.args.target[0] 907 target = self.args.target[0]
897 isolate_map = self.ReadIsolateMap() 908 isolate_map = self.ReadIsolateMap()
898 err, labels = self.MapTargetsToLabels(isolate_map, [target]) 909 err, labels = self.MapTargetsToLabels(isolate_map, [target])
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
1543 # Then check to see if the arg contains any metacharacters other than 1554 # Then check to see if the arg contains any metacharacters other than
1544 # double quotes; if it does, quote everything (including the double 1555 # double quotes; if it does, quote everything (including the double
1545 # quotes) for safety. 1556 # quotes) for safety.
1546 if any(a in UNSAFE_FOR_CMD for a in arg): 1557 if any(a in UNSAFE_FOR_CMD for a in arg):
1547 arg = ''.join('^' + a if a in ALL_META_CHARS else a for a in arg) 1558 arg = ''.join('^' + a if a in ALL_META_CHARS else a for a in arg)
1548 return arg 1559 return arg
1549 1560
1550 1561
1551 if __name__ == '__main__': 1562 if __name__ == '__main__':
1552 sys.exit(main(sys.argv[1:])) 1563 sys.exit(main(sys.argv[1:]))
OLDNEW
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698