Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: webrtc/modules/desktop_capture/win/screen_capture_utils.cc

Issue 2971393002: Output DeviceName from various windows ScreenCapturer related implementations (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/win/screen_capture_utils.cc
diff --git a/webrtc/modules/desktop_capture/win/screen_capture_utils.cc b/webrtc/modules/desktop_capture/win/screen_capture_utils.cc
index 9fa5c8b12db42a1816998c224ea25947b2b7b1ff..2dbb2690d1627a935d7ab116dd89554bff766e51 100644
--- a/webrtc/modules/desktop_capture/win/screen_capture_utils.cc
+++ b/webrtc/modules/desktop_capture/win/screen_capture_utils.cc
@@ -13,6 +13,7 @@
#include <windows.h>
#include "webrtc/rtc_base/checks.h"
+#include "webrtc/rtc_base/win32.h"
namespace webrtc {
@@ -33,7 +34,7 @@ bool GetScreenList(DesktopCapturer::SourceList* screens) {
if (!(device.StateFlags & DISPLAY_DEVICE_ACTIVE))
continue;
- screens->push_back({device_index, std::string()});
+ screens->push_back({device_index, rtc::ToUtf8(device.DeviceName)});
Do not use (sergeyu) 2017/07/11 18:21:09 title field is normally used for the title strings
Hzj_jie 2017/07/11 19:09:25 The string is in format of \\.\Display{id}. But fo
Sergey Ulanov 2017/07/11 21:34:22 Even if this field is not used right now it's stil
Hzj_jie 2017/07/11 21:48:32 Done.
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698