Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.h

Issue 2970923002: vp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp. (Closed)
Patch Set: rename Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.h
diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h
index 376dde1280819bb8fee321754bfd3fbf2a6a59ba..8f78435593d6196f6bf27d8b345c08db64715e37 100644
--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h
+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h
@@ -135,7 +135,14 @@ class VP8DecoderImpl : public VP8Decoder {
const char* ImplementationName() const override;
+ struct DeblockParams {
+ int level = 6; // Deblocking strength: [0, 16]
brandtr 2017/08/09 10:50:39 Maybe name this |max_level| ? nit: period at end
åsapersson 2017/08/09 14:03:27 Done.
+ int degrade_qp = 80; // If the QP value is below, start lowering |level|.
+ int min_qp = 40; // If the QP value is below, turn off deblocking.
+ };
+
private:
+ class QpSmoother;
int ReturnFrame(const vpx_image_t* img,
uint32_t timeStamp,
int64_t ntp_time_ms,
@@ -151,6 +158,8 @@ class VP8DecoderImpl : public VP8Decoder {
int last_frame_width_;
int last_frame_height_;
bool key_frame_required_;
+ DeblockParams deblock_;
+ const std::unique_ptr<QpSmoother> qp_;
brandtr 2017/08/09 10:50:39 |qp_smoother_| ?
åsapersson 2017/08/09 14:03:28 Done.
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698