webrtc/modules/congestion_controller/send_side_congestion_controller.cc - Issue 2970653004: Reimplemeted "Test and fix for huge bwe drop after alr state"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/send_side_congestion_controller.cc

Issue 2970653004: Reimplemeted "Test and fix for huge bwe drop after alr state" (Closed)

Patch Set: Response to comments. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/bitrate_estimator.cc ('K') | « webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/send_side_congestion_controller.cc

diff --git a/webrtc/modules/congestion_controller/send_side_congestion_controller.cc b/webrtc/modules/congestion_controller/send_side_congestion_controller.cc

index d5f966aeaa7818d721c53aef4e6caf2f50121b1d..0972ccda2b33353235962063db7f6637b7211f65 100644

--- a/webrtc/modules/congestion_controller/send_side_congestion_controller.cc

+++ b/webrtc/modules/congestion_controller/send_side_congestion_controller.cc

@@ -20,7 +20,7 @@

#include "webrtc/base/rate_limiter.h"

#include "webrtc/base/socket.h"

#include "webrtc/modules/bitrate_controller/include/bitrate_controller.h"

-#include "webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.h"

+#include "webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h"

#include "webrtc/modules/congestion_controller/probe_controller.h"

#include "webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h"

@@ -278,7 +278,8 @@ void SendSideCongestionController::OnTransportFeedback(

transport_feedback_adapter_.GetTransportFeedbackVector());

SortPacketFeedbackVector(&feedback_vector);

acknowledged_bitrate_estimator_->IncomingPacketFeedbackVector(

- feedback_vector);

+ feedback_vector,

+ static_cast<bool>(pacer_->GetApplicationLimitedRegionStartTime()));

DelayBasedBwe::Result result;

{

rtc::CritScope cs(&bwe_lock_);