webrtc/modules/congestion_controller/include/send_side_congestion_controller.h - Issue 2970653004: Reimplemeted "Test and fix for huge bwe drop after alr state"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

Issue 2970653004: Reimplemeted "Test and fix for huge bwe drop after alr state" (Closed)

Patch Set: Fix uninitialized variable Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h ('k') | webrtc/modules/congestion_controller/send_side_congestion_controller.cc » ('j') | webrtc/modules/pacing/alr_detector.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

diff --git a/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h b/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

index 7a8f362c312335ebc37c4880712075256101aaab..8a1d16f49bc26b1b82c9f0624ae21bac0e9ae655 100644

--- a/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

+++ b/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

@@ -32,6 +32,7 @@ struct SentPacket;

namespace webrtc {

+class AlrState;

class BitrateController;

class Clock;

class AcknowledgedBitrateEstimator;

@@ -154,6 +155,7 @@ class SendSideCongestionController : public CallStatsObserver,

rtc::CriticalSection bwe_lock_;

int min_bitrate_bps_ GUARDED_BY(bwe_lock_);

std::unique_ptr<DelayBasedBwe> delay_based_bwe_ GUARDED_BY(bwe_lock_);

+ const std::unique_ptr<AlrState> alr_state_;

philipel 2017/07/14 13:56:23 No need for this to be a unique_ptr.

tschumi 2017/07/14 15:36:51 Removed AlrState

rtc::RaceChecker worker_race_;