webrtc/rtc_base/messagequeue.h - Issue 2968753002: Support re-entrant calls to MessageQueueManager::Clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/rtc_base/messagequeue.h

Issue 2968753002: Support re-entrant calls to MessageQueueManager::Clear. (Closed)

Patch Set: Rebased Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/rtc_base/messagequeue.h

diff --git a/webrtc/rtc_base/messagequeue.h b/webrtc/rtc_base/messagequeue.h

index d4057cd2df791dd6c8180aeb2f9788432aad06dd..5d7ed08aefde918d2c13a713d91ef01acd6e3e57 100644

--- a/webrtc/rtc_base/messagequeue.h

+++ b/webrtc/rtc_base/messagequeue.h

@@ -70,9 +70,8 @@ class MessageQueueManager {

// This list contains all live MessageQueues.

std::vector<MessageQueue*> message_queues_ GUARDED_BY(crit_);

- // Acquire this with DebugNonReentrantCritScope.

CriticalSection crit_;

- bool locked_ GUARDED_BY(crit_);

+ size_t processing_ GUARDED_BY(crit_);

Taylor Brandstetter 2017/07/05 22:41:47 It would be nice if there was a comment describing

joachim 2017/07/05 23:03:11 Done.

};

// Derive from this for specialized data

« no previous file with comments | « no previous file | webrtc/rtc_base/messagequeue.cc » ('j') | webrtc/rtc_base/messagequeue.cc » ('J')