webrtc/call/rtp_stream_receiver_controller.cc - Issue 2968693002: SSRC and RSID may only refer to one sink each in RtpDemuxer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call/rtp_stream_receiver_controller.cc

Issue 2968693002: SSRC and RSID may only refer to one sink each in RtpDemuxer (Closed)

Patch Set: TODO added. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/call/rtp_stream_receiver_controller.cc

diff --git a/webrtc/call/rtp_stream_receiver_controller.cc b/webrtc/call/rtp_stream_receiver_controller.cc

index a4b1e36ae262c1951479c36b57e07ea71a76041d..743ae02254831c788967be363956b798ce34ae5b 100644

--- a/webrtc/call/rtp_stream_receiver_controller.cc

+++ b/webrtc/call/rtp_stream_receiver_controller.cc

@@ -46,7 +46,7 @@ bool RtpStreamReceiverController::OnRtpPacket(const RtpPacketReceived& packet) {

void RtpStreamReceiverController::AddSink(uint32_t ssrc,

RtpPacketSinkInterface* sink) {

rtc::CritScope cs(&lock_);

- return demuxer_.AddSink(ssrc, sink);

+ demuxer_.AddSink(ssrc, sink); // TODO(eladalon): Return-value useful here?

}

size_t RtpStreamReceiverController::RemoveSink(