SSRC and RSID may only refer to one sink each in RtpDemuxer

webrtc/call/rtp_stream_receiver_controller.cc

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 28 matching lines @@
 }
 
 bool RtpStreamReceiverController::OnRtpPacket(const RtpPacketReceived& packet) {
   rtc::CritScope cs(&lock_);
   return demuxer_.OnRtpPacket(packet);
 }
 
 void RtpStreamReceiverController::AddSink(uint32_t ssrc,
                                           RtpPacketSinkInterface* sink) {
   rtc::CritScope cs(&lock_);
-  return demuxer_.AddSink(ssrc, sink);
+  demuxer_.AddSink(ssrc, sink);  // TODO(eladalon): Return-value useful here?

[eladalon, 2017/06/30 12:53:24]

Reviewers - input welcome!

[danilchap, 2017/06/30 16:45:31]

might be helpful.
either return bool, or RTC_CHECK() sink was added.

Otherwise if AddSink will fail it will be hard to understand what's going on.

[eladalon, 2017/07/03 08:23:35]

Done.

 }
 
 size_t RtpStreamReceiverController::RemoveSink(
     const RtpPacketSinkInterface* sink) {
   rtc::CritScope cs(&lock_);
   return demuxer_.RemoveSink(sink);
 }
 
 }  // namespace webrtc