Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc

Issue 2968003003: Stop silently accepting unsupported flags in test binaries (Closed)
Patch Set: Add TODO Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools_webrtc/valgrind/webrtc_tests.py ('k') | webrtc/test/test_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc
diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc b/webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc
index e39f1efa26c8eee1623ef7950ccf71e00f870e5c..79a525bccfd8cfbddf5a6d4f7889ac0211511114 100644
--- a/webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc
+++ b/webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc
@@ -384,10 +384,8 @@ TEST(IsacFixTest, Kenny) {
sscanf(argv[CodingMode+1], "%s", bottleneck_file);
f_bn = fopen(bottleneck_file, "rb");
if (f_bn == NULL) {
- printf("No value provided for BottleNeck and cannot read file %s\n",
- bottleneck_file);
- exit(0); // TODO(oprypin): don't silence this error
- // FAIL() << "Cannot read file " << bottleneck_file;
+ printf("No value provided for BottleNeck\n");
+ FAIL() << "Cannot read file " << bottleneck_file;
} else {
int aux_var;
printf("reading bottleneck rates from file %s\n\n",bottleneck_file);
« no previous file with comments | « tools_webrtc/valgrind/webrtc_tests.py ('k') | webrtc/test/test_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698