Get rid of unnecessary cast of FlexfecReceiveStreamImpl to FlexfecReceiveStream

webrtc/call/flexfec_receive_stream_impl.h

Index: webrtc/call/flexfec_receive_stream_impl.h
diff --git a/webrtc/call/flexfec_receive_stream_impl.h b/webrtc/call/flexfec_receive_stream_impl.h
index a89940f8c3e52d9bb01e46eeea682f69aac882de..6a4eeae3e317e7f52cd1fdae5eec2bf3802a0bdf 100644
--- a/webrtc/call/flexfec_receive_stream_impl.h
+++ b/webrtc/call/flexfec_receive_stream_impl.h
@@ -40,8 +40,6 @@ class FlexfecReceiveStreamImpl : public FlexfecReceiveStream,
       ProcessThread* process_thread);
   ~FlexfecReceiveStreamImpl() override;
 
-  const Config& GetConfig() const { return config_; }
-
   // RtpPacketSinkInterface.
   void OnRtpPacket(const RtpPacketReceived& packet) override;
 
@@ -50,6 +48,8 @@ class FlexfecReceiveStreamImpl : public FlexfecReceiveStream,
   void Stop() override;
   Stats GetStats() const override;
 
+  const Config& GetConfig() const override;

[eladalon, 2017/07/04 09:56:26]

Might also be a good idea to return a copy of the Config, rather than a
reference to it. Otherwise, we have no guarantee nobody would be using it past
its lifetime. (Separate issue for a separate CL, though.) What do you think?

[ossu, 2017/07/21 13:07:15]

IMO, there's no reason to return a copy unless access to the Config must be
serialized (thus necessitating a serialized copy in GetConfig()). Nobody should
keep references inside other objects around. If the caller needs to retain a
Config, it's super easy for them to copy it during the GetConfig() call (or
later).

[eladalon, 2017/07/21 13:19:31]

I was thinking about fool-proofing it, but I guess you're right - if returning a
temporarily valid handle is good enough for the STL (std::string::c_str), it
should be good enough for me; copying comes at a price, after all.

+
  private:
   // Config.
   const Config config_;