Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter.cc

Issue 2966403002: Added implementation of three classes in BBR,with unit-tests. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter.cc
new file mode 100644
index 0000000000000000000000000000000000000000..64df98e4f385084d8ee58d2d1783e22fc18ff3d3
--- /dev/null
+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter.cc
@@ -0,0 +1,24 @@
+/*
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ *
+ */
+
+#include "webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter.h"
philipel 2017/07/06 12:15:15 This class is small enough to not have a .cc file,
gnish1 2017/07/07 13:43:34 Done.
+
+namespace webrtc {
+namespace testing {
+namespace bwe {
+MinRttFilter::MinRttFilter() : min_rtt_(10000000), discovery_time_(0) {}
philipel 2017/07/06 12:15:16 Use std::numeric_limits<int64_t>::max() instead of
gnish1 2017/07/07 13:43:34 Done.
+MinRttFilter::~MinRttFilter() {}
+void MinRttFilter::UpdateMinRtt(int64_t min_rtt) {
philipel 2017/07/06 12:15:16 Don't you want a AddRttSample(int64_t rtt_ms, int6
gnish1 2017/07/07 13:43:34 Done.
+ min_rtt_ = min_rtt;
stefan-webrtc 2017/07/06 13:39:25 This doesn't look like a min filter?
gnish1 2017/07/07 13:43:34 Done.
+}
+} // namespace bwe
+} // namespace testing
+} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698