Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: webrtc/common_audio/BUILD.gn

Issue 2966173002: Moving asm code out of common_audio_c sources list (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_audio/BUILD.gn
diff --git a/webrtc/common_audio/BUILD.gn b/webrtc/common_audio/BUILD.gn
index 386a8311c5355fcad5be04b46610a2c27d7f350b..ff0aa267fd9a75e077eb6798ff20e8283849e16b 100644
--- a/webrtc/common_audio/BUILD.gn
+++ b/webrtc/common_audio/BUILD.gn
@@ -103,6 +103,23 @@ rtc_static_library("common_audio") {
}
}
+rtc_source_set("common_audio_c_arm_asm") {
+ visibility = [ ":*" ] # Only targets in this file can depend on this.
+ sources = []
+ if (current_cpu == "arm") {
+ sources += [
+ "signal_processing/complex_bit_reverse_arm.S",
+ "signal_processing/spl_sqrt_floor_arm.S",
+ ]
+
+ if (arm_version >= 7) {
+ sources += [ "signal_processing/filter_ar_fast_q12_armv7.S" ]
+ } else {
+ sources += [ "signal_processing/filter_ar_fast_q12.c" ]
+ }
+ }
+}
+
rtc_source_set("common_audio_c") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
@@ -156,19 +173,6 @@ rtc_source_set("common_audio_c") {
"vad/webrtc_vad.c",
]
- if (current_cpu == "arm") {
- sources += [
- "signal_processing/complex_bit_reverse_arm.S",
- "signal_processing/spl_sqrt_floor_arm.S",
- ]
-
- if (arm_version >= 7) {
- sources += [ "signal_processing/filter_ar_fast_q12_armv7.S" ]
- } else {
- sources += [ "signal_processing/filter_ar_fast_q12.c" ]
- }
- }
-
if (current_cpu == "mipsel") {
sources += [
"signal_processing/complex_bit_reverse_mips.c",
@@ -202,6 +206,7 @@ rtc_source_set("common_audio_c") {
public_configs = [ ":common_audio_config" ]
deps = [
+ ":common_audio_c_arm_asm",
":common_audio_cc",
"..:webrtc_common",
"../base:compile_assert_c",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698