Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: webrtc/video/video_quality_test.cc

Issue 2965503006: Fix receiving FlexFEC in video_loopback. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_quality_test.cc
diff --git a/webrtc/video/video_quality_test.cc b/webrtc/video/video_quality_test.cc
index 37b47867d31db785967a08ef71384862c40651da..5946405b5079d65e025c321c0092913b8274a15d 100644
--- a/webrtc/video/video_quality_test.cc
+++ b/webrtc/video/video_quality_test.cc
@@ -1874,7 +1874,6 @@ void VideoQualityTest::RunWithRenderers(const Params& params) {
send_transport.SetReceiver(receiver_call_->Receiver());
recv_transport.SetReceiver(sender_call_->Receiver());
- FlexfecReceiveStream* flexfec_receive_stream = nullptr;
std::unique_ptr<test::VideoRenderer> local_preview;
std::vector<std::unique_ptr<test::VideoRenderer>> loopback_renderers_;
if (params_.video.enabled) {
@@ -1939,8 +1938,10 @@ void VideoQualityTest::RunWithRenderers(const Params& params) {
// Start sending and receiving video.
if (params_.video.enabled) {
- if (flexfec_receive_stream)
+ for (FlexfecReceiveStream* flexfec_receive_stream :
+ flexfec_receive_streams_) {
flexfec_receive_stream->Start();
+ }
for (VideoReceiveStream* receive_stream : video_receive_streams_)
receive_stream->Start();
video_send_stream_->Start();
@@ -1975,14 +1976,15 @@ void VideoQualityTest::RunWithRenderers(const Params& params) {
if (params_.video.enabled) {
video_capturer_->Stop();
video_send_stream_->Stop();
- for (VideoReceiveStream* receive_stream : video_receive_streams_)
- receive_stream->Stop();
- if (flexfec_receive_stream) {
+ for (FlexfecReceiveStream* flexfec_receive_stream :
+ flexfec_receive_streams_) {
flexfec_receive_stream->Stop();
receiver_call_->DestroyFlexfecReceiveStream(flexfec_receive_stream);
}
- for (VideoReceiveStream* receive_stream : video_receive_streams_)
+ for (VideoReceiveStream* receive_stream : video_receive_streams_) {
+ receive_stream->Stop();
receiver_call_->DestroyVideoReceiveStream(receive_stream);
+ }
sender_call_->DestroyVideoSendStream(video_send_stream_);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698