Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: webrtc/video/video_quality_test.cc

Issue 2964953002: Remove webrtc::VideoEncoderFactory (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/video_quality_test.cc
diff --git a/webrtc/video/video_quality_test.cc b/webrtc/video/video_quality_test.cc
index 5e99b50ff0c297404be5e8eca2e75001b4e953e5..64db303ac9b8a1dfd66f8b3994331724b8b7f090 100644
--- a/webrtc/video/video_quality_test.cc
+++ b/webrtc/video/video_quality_test.cc
@@ -1037,24 +1037,32 @@ class VideoAnalyzer : public PacketReceiver,
rtc::Event done_;
};
-class Vp8EncoderFactory : public VideoEncoderFactory {
+class Vp8EncoderFactory : public cricket::WebRtcVideoEncoderFactory {
public:
- Vp8EncoderFactory() = default;
+ Vp8EncoderFactory() {
+ supported_codecs_.push_back(cricket::VideoCodec("VP8"));
+ }
~Vp8EncoderFactory() override { RTC_CHECK(live_encoders_.empty()); }
- VideoEncoder* Create() override {
+ const std::vector<cricket::VideoCodec>& supported_codecs() const override {
+ return supported_codecs_;
+ }
+
+ VideoEncoder* CreateVideoEncoder(const cricket::VideoCodec& codec) override {
VideoEncoder* encoder = VP8Encoder::Create();
live_encoders_.insert(encoder);
return encoder;
}
- void Destroy(VideoEncoder* encoder) override {
+ void DestroyVideoEncoder(VideoEncoder* encoder) override {
auto it = live_encoders_.find(encoder);
RTC_CHECK(it != live_encoders_.end());
live_encoders_.erase(it);
delete encoder;
}
+ private:
+ std::vector<cricket::VideoCodec> supported_codecs_;
std::set<VideoEncoder*> live_encoders_;
};

Powered by Google App Engine
This is Rietveld 408576698