Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: webrtc/video/picture_id_tests.cc

Issue 2964953002: Remove webrtc::VideoEncoderFactory (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/picture_id_tests.cc
diff --git a/webrtc/video/picture_id_tests.cc b/webrtc/video/picture_id_tests.cc
index fe39a946b974af7183b80a6724994f90b4bb6bbb..6295ea39f96a6ee1f3c4d353b9be8fa9a0836799 100644
--- a/webrtc/video/picture_id_tests.cc
+++ b/webrtc/video/picture_id_tests.cc
@@ -9,7 +9,7 @@
*/
#include "webrtc/media/engine/internalencoderfactory.h"
#include "webrtc/modules/rtp_rtcp/source/rtp_format.h"
-#include "webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h"
+#include "webrtc/media/engine/simulcast_encoder_adapter.h"
#include "webrtc/modules/video_coding/sequence_number_util.h"
#include "webrtc/test/call_test.h"
@@ -291,32 +291,10 @@ TEST_F(PictureIdTest, PictureIdIncreasingAfterStreamCountChangeVp8) {
TestPictureIdContinuousAfterReconfigure(ssrc_counts);
}
-class VideoEncoderFactoryAdapter : public webrtc::VideoEncoderFactory {
- public:
- explicit VideoEncoderFactoryAdapter(
- cricket::WebRtcVideoEncoderFactory* factory)
- : factory_(factory) {}
- virtual ~VideoEncoderFactoryAdapter() {}
-
- // Implements webrtc::VideoEncoderFactory.
- webrtc::VideoEncoder* Create() override {
- return factory_->CreateVideoEncoder(
- cricket::VideoCodec(cricket::kVp8CodecName));
- }
-
- void Destroy(webrtc::VideoEncoder* encoder) override {
- return factory_->DestroyVideoEncoder(encoder);
- }
-
- private:
- cricket::WebRtcVideoEncoderFactory* const factory_;
-};
-
TEST_F(PictureIdTest,
PictureIdContinuousAfterReconfigureSimulcastEncoderAdapter) {
cricket::InternalEncoderFactory internal_encoder_factory;
- SimulcastEncoderAdapter simulcast_encoder_adapter(
- new VideoEncoderFactoryAdapter(&internal_encoder_factory));
+ SimulcastEncoderAdapter simulcast_encoder_adapter(&internal_encoder_factory);
SetupEncoder(&simulcast_encoder_adapter);
TestPictureIdContinuousAfterReconfigure({1, 3, 3, 1, 1});
}
@@ -324,8 +302,7 @@ TEST_F(PictureIdTest,
TEST_F(PictureIdTest,
PictureIdIncreasingAfterRecreateStreamSimulcastEncoderAdapter) {
cricket::InternalEncoderFactory internal_encoder_factory;
- SimulcastEncoderAdapter simulcast_encoder_adapter(
- new VideoEncoderFactoryAdapter(&internal_encoder_factory));
+ SimulcastEncoderAdapter simulcast_encoder_adapter(&internal_encoder_factory);
SetupEncoder(&simulcast_encoder_adapter);
TestPictureIdIncreaseAfterRecreateStreams({1, 3, 3, 1, 1});
}
@@ -337,8 +314,7 @@ TEST_F(
PictureIdTest,
DISABLED_PictureIdIncreasingAfterStreamCountChangeSimulcastEncoderAdapter) {
cricket::InternalEncoderFactory internal_encoder_factory;
- SimulcastEncoderAdapter simulcast_encoder_adapter(
- new VideoEncoderFactoryAdapter(&internal_encoder_factory));
+ SimulcastEncoderAdapter simulcast_encoder_adapter(&internal_encoder_factory);
// Make sure that that the picture id is not reset if the stream count goes
// down and then up.
std::vector<int> ssrc_counts = {3, 1, 3};

Powered by Google App Engine
This is Rietveld 408576698