Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: webrtc/media/engine/webrtcvideoengine.cc

Issue 2964953002: Remove webrtc::VideoEncoderFactory (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvideoengine.cc
diff --git a/webrtc/media/engine/webrtcvideoengine.cc b/webrtc/media/engine/webrtcvideoengine.cc
index e592740bb9260b3c6594514930a1793dca4c96af..b9451f13eeb135761394d7a0e7e04cf9a7fb15a9 100644
--- a/webrtc/media/engine/webrtcvideoengine.cc
+++ b/webrtc/media/engine/webrtcvideoengine.cc
@@ -35,7 +35,7 @@
#include "webrtc/media/engine/webrtcmediaengine.h"
#include "webrtc/media/engine/webrtcvideoencoderfactory.h"
#include "webrtc/media/engine/webrtcvoiceengine.h"
-#include "webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h"
+#include "webrtc/media/engine/simulcast_encoder_adapter.h"
stefan-webrtc 2017/07/07 09:55:21 Sort
magjed_webrtc 2017/07/07 12:08:00 Done.
#include "webrtc/system_wrappers/include/field_trial.h"
using DegradationPreference = webrtc::VideoSendStream::DegradationPreference;
@@ -62,28 +62,6 @@ bool IsVideoContentTypeExtensionFieldTrialEnabled() {
return webrtc::field_trial::IsEnabled("WebRTC-VideoContentTypeExtension");
}
-// Wrap cricket::WebRtcVideoEncoderFactory as a webrtc::VideoEncoderFactory.
-class EncoderFactoryAdapter : public webrtc::VideoEncoderFactory {
- public:
- // EncoderFactoryAdapter doesn't take ownership of |factory|, which is owned
- // by e.g. PeerConnectionFactory.
- explicit EncoderFactoryAdapter(cricket::WebRtcVideoEncoderFactory* factory)
- : factory_(factory) {}
- virtual ~EncoderFactoryAdapter() {}
-
- // Implement webrtc::VideoEncoderFactory.
- webrtc::VideoEncoder* Create() override {
- return factory_->CreateVideoEncoder(VideoCodec(kVp8CodecName));
- }
-
- void Destroy(webrtc::VideoEncoder* encoder) override {
- return factory_->DestroyVideoEncoder(encoder);
- }
-
- private:
- cricket::WebRtcVideoEncoderFactory* const factory_;
-};
-
// An encoder factory that wraps Create requests for simulcastable codec types
// with a webrtc::SimulcastEncoderAdapter. Non simulcastable codec type
// requests are just passed through to the contained encoder factory.
@@ -113,8 +91,7 @@ class WebRtcSimulcastEncoderFactory
RTC_DCHECK(factory_ != NULL);
// If it's a codec type we can simulcast, create a wrapped encoder.
if (CodecNamesEq(codec.name.c_str(), kVp8CodecName)) {
- return new webrtc::SimulcastEncoderAdapter(
- new EncoderFactoryAdapter(factory_));
+ return new webrtc::SimulcastEncoderAdapter(factory_);
}
webrtc::VideoEncoder* encoder = factory_->CreateVideoEncoder(codec);
if (encoder) {

Powered by Google App Engine
This is Rietveld 408576698