Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2964593002: Adding stats that can be used to compute output audio levels. (Closed)
Patch Set: Add test coverage in AudioSendStreamTest. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | webrtc/pc/rtcstatscollector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 verifier.TestMemberIsUndefined(media_stream_track.frames_dropped); 468 verifier.TestMemberIsUndefined(media_stream_track.frames_dropped);
469 } 469 }
470 verifier.TestMemberIsUndefined(media_stream_track.frames_corrupted); 470 verifier.TestMemberIsUndefined(media_stream_track.frames_corrupted);
471 verifier.TestMemberIsUndefined(media_stream_track.partial_frames_lost); 471 verifier.TestMemberIsUndefined(media_stream_track.partial_frames_lost);
472 verifier.TestMemberIsUndefined(media_stream_track.full_frames_lost); 472 verifier.TestMemberIsUndefined(media_stream_track.full_frames_lost);
473 // Audio-only members should be undefined 473 // Audio-only members should be undefined
474 verifier.TestMemberIsUndefined(media_stream_track.audio_level); 474 verifier.TestMemberIsUndefined(media_stream_track.audio_level);
475 verifier.TestMemberIsUndefined(media_stream_track.echo_return_loss); 475 verifier.TestMemberIsUndefined(media_stream_track.echo_return_loss);
476 verifier.TestMemberIsUndefined( 476 verifier.TestMemberIsUndefined(
477 media_stream_track.echo_return_loss_enhancement); 477 media_stream_track.echo_return_loss_enhancement);
478 verifier.TestMemberIsUndefined(media_stream_track.total_audio_energy);
479 verifier.TestMemberIsUndefined(media_stream_track.total_samples_duration);
478 } else { 480 } else {
479 RTC_DCHECK_EQ(*media_stream_track.kind, 481 RTC_DCHECK_EQ(*media_stream_track.kind,
480 RTCMediaStreamTrackKind::kAudio); 482 RTCMediaStreamTrackKind::kAudio);
481 // Video-only members should be undefined 483 // Video-only members should be undefined
482 verifier.TestMemberIsUndefined(media_stream_track.frame_width); 484 verifier.TestMemberIsUndefined(media_stream_track.frame_width);
483 verifier.TestMemberIsUndefined(media_stream_track.frame_height); 485 verifier.TestMemberIsUndefined(media_stream_track.frame_height);
484 verifier.TestMemberIsUndefined(media_stream_track.frames_per_second); 486 verifier.TestMemberIsUndefined(media_stream_track.frames_per_second);
485 verifier.TestMemberIsUndefined(media_stream_track.frames_sent); 487 verifier.TestMemberIsUndefined(media_stream_track.frames_sent);
486 verifier.TestMemberIsUndefined(media_stream_track.frames_received); 488 verifier.TestMemberIsUndefined(media_stream_track.frames_received);
487 verifier.TestMemberIsUndefined(media_stream_track.frames_decoded); 489 verifier.TestMemberIsUndefined(media_stream_track.frames_decoded);
488 verifier.TestMemberIsUndefined(media_stream_track.frames_dropped); 490 verifier.TestMemberIsUndefined(media_stream_track.frames_dropped);
489 verifier.TestMemberIsUndefined(media_stream_track.frames_corrupted); 491 verifier.TestMemberIsUndefined(media_stream_track.frames_corrupted);
490 verifier.TestMemberIsUndefined(media_stream_track.partial_frames_lost); 492 verifier.TestMemberIsUndefined(media_stream_track.partial_frames_lost);
491 verifier.TestMemberIsUndefined(media_stream_track.full_frames_lost); 493 verifier.TestMemberIsUndefined(media_stream_track.full_frames_lost);
492 // Audio-only members 494 // Audio-only members
493 verifier.TestMemberIsNonNegative<double>(media_stream_track.audio_level); 495 verifier.TestMemberIsNonNegative<double>(media_stream_track.audio_level);
496 verifier.TestMemberIsNonNegative<double>(
497 media_stream_track.total_audio_energy);
498 verifier.TestMemberIsNonNegative<double>(
499 media_stream_track.total_samples_duration);
494 // TODO(hbos): |echo_return_loss| and |echo_return_loss_enhancement| are 500 // TODO(hbos): |echo_return_loss| and |echo_return_loss_enhancement| are
495 // flaky on msan bot (sometimes defined, sometimes undefined). Should the 501 // flaky on msan bot (sometimes defined, sometimes undefined). Should the
496 // test run until available or is there a way to have it always be 502 // test run until available or is there a way to have it always be
497 // defined? crbug.com/627816 503 // defined? crbug.com/627816
498 verifier.MarkMemberTested(media_stream_track.echo_return_loss, true); 504 verifier.MarkMemberTested(media_stream_track.echo_return_loss, true);
499 verifier.MarkMemberTested( 505 verifier.MarkMemberTested(
500 media_stream_track.echo_return_loss_enhancement, true); 506 media_stream_track.echo_return_loss_enhancement, true);
501 } 507 }
502 return verifier.ExpectAllMembersSuccessfullyTested(); 508 return verifier.ExpectAllMembersSuccessfullyTested();
503 } 509 }
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 caller_ = nullptr; 649 caller_ = nullptr;
644 // Any pending stats requests should have completed in the act of destroying 650 // Any pending stats requests should have completed in the act of destroying
645 // the peer connection. 651 // the peer connection.
646 EXPECT_TRUE(stats_obtainer->report()); 652 EXPECT_TRUE(stats_obtainer->report());
647 } 653 }
648 #endif // HAVE_SCTP 654 #endif // HAVE_SCTP
649 655
650 } // namespace 656 } // namespace
651 657
652 } // namespace webrtc 658 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | webrtc/pc/rtcstatscollector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698