Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: webrtc/ortc/testrtpparameters.cc

Issue 2963543002: Fixing bad use of std::sort in test method. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/ortc/testrtpparameters.cc
diff --git a/webrtc/ortc/testrtpparameters.cc b/webrtc/ortc/testrtpparameters.cc
index de2e7d5bd20bc6ccee8f70db61b769f6e664ac14..5d1cdf96350dcf1f858b2572a11fab87f8ca0c28 100644
--- a/webrtc/ortc/testrtpparameters.cc
+++ b/webrtc/ortc/testrtpparameters.cc
@@ -163,11 +163,13 @@ RtpParameters MakeFullAudioParameters(int preferred_payload_type) {
// "codec_payload_type" isn't implemented, so we need to reorder codecs to
// cause one to be used.
// TODO(deadbeef): Remove this when it becomes unnecessary.
- std::sort(parameters.codecs.begin(), parameters.codecs.end(),
- [preferred_payload_type](const RtpCodecParameters& a,
- const RtpCodecParameters& b) {
- return a.payload_type == preferred_payload_type;
- });
+ auto it = std::find_if(parameters.codecs.begin(), parameters.codecs.end(),
+ [preferred_payload_type](const RtpCodecParameters& p) {
+ return p.payload_type == preferred_payload_type;
+ });
+ RtpCodecParameters preferred = *it;
+ parameters.codecs.erase(it);
+ parameters.codecs.insert(parameters.codecs.begin(), preferred);
// Intentionally leave out SSRC so one's chosen automatically.
RtpEncodingParameters encoding;
@@ -270,11 +272,13 @@ RtpParameters MakeFullVideoParameters(int preferred_payload_type) {
// "codec_payload_type" isn't implemented, so we need to reorder codecs to
// cause one to be used.
// TODO(deadbeef): Remove this when it becomes unnecessary.
- std::sort(parameters.codecs.begin(), parameters.codecs.end(),
- [preferred_payload_type](const RtpCodecParameters& a,
- const RtpCodecParameters& b) {
- return a.payload_type == preferred_payload_type;
- });
+ auto it = std::find_if(parameters.codecs.begin(), parameters.codecs.end(),
+ [preferred_payload_type](const RtpCodecParameters& p) {
+ return p.payload_type == preferred_payload_type;
+ });
+ RtpCodecParameters preferred = *it;
+ parameters.codecs.erase(it);
+ parameters.codecs.insert(parameters.codecs.begin(), preferred);
// Intentionally leave out SSRC so one's chosen automatically.
RtpEncodingParameters encoding;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698