Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: webrtc/voice_engine/voe_base_unittest.cc

Issue 2961723004: Allow an external audio processing module to be used in WebRTC (Closed)
Patch Set: Moved creation of APMs from CreateVoiceEngines Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/voice_engine/voe_base_impl.cc ('k') | webrtc/voice_engine/voe_codec_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/voe_base_unittest.cc
diff --git a/webrtc/voice_engine/voe_base_unittest.cc b/webrtc/voice_engine/voe_base_unittest.cc
index a300f3b75e9cfee6b598344ffea998a6535e5b82..55f9634a837b200d00228915f8cc79ba7e3b8e58 100644
--- a/webrtc/voice_engine/voe_base_unittest.cc
+++ b/webrtc/voice_engine/voe_base_unittest.cc
@@ -21,17 +21,8 @@ namespace webrtc {
class VoEBaseTest : public VoiceEngineFixture {};
-TEST_F(VoEBaseTest, InitWithExternalAudioDeviceAndAudioProcessing) {
- AudioProcessing* audioproc = AudioProcessing::Create();
- EXPECT_EQ(0, base_->Init(&adm_, audioproc));
- EXPECT_EQ(audioproc, base_->audio_processing());
- EXPECT_EQ(0, base_->LastError());
-}
-
TEST_F(VoEBaseTest, InitWithExternalAudioDevice) {
- EXPECT_EQ(nullptr, base_->audio_processing());
- EXPECT_EQ(0, base_->Init(&adm_, nullptr));
- EXPECT_NE(nullptr, base_->audio_processing());
+ EXPECT_EQ(0, base_->Init(&adm_, apm_.get()));
EXPECT_EQ(0, base_->LastError());
}
@@ -41,15 +32,14 @@ TEST_F(VoEBaseTest, CreateChannelBeforeInitShouldFail) {
}
TEST_F(VoEBaseTest, CreateChannelAfterInit) {
- EXPECT_EQ(0, base_->Init(&adm_, nullptr));
+ EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
int channelID = base_->CreateChannel();
EXPECT_NE(channelID, -1);
EXPECT_EQ(0, base_->DeleteChannel(channelID));
}
TEST_F(VoEBaseTest, AssociateSendChannel) {
- AudioProcessing* audioproc = AudioProcessing::Create();
- EXPECT_EQ(0, base_->Init(&adm_, audioproc));
+ EXPECT_EQ(0, base_->Init(&adm_, apm_.get()));
const int channel_1 = base_->CreateChannel();
« no previous file with comments | « webrtc/voice_engine/voe_base_impl.cc ('k') | webrtc/voice_engine/voe_codec_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698