Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: webrtc/voice_engine/voe_base_impl.h

Issue 2961723004: Allow an external audio processing module to be used in WebRTC (Closed)
Patch Set: Moved creation of APMs from CreateVoiceEngines Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/voice_engine/test/auto_test/standard/codec_test.cc ('k') | webrtc/voice_engine/voe_base_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/voe_base_impl.h
diff --git a/webrtc/voice_engine/voe_base_impl.h b/webrtc/voice_engine/voe_base_impl.h
index b9f328259606f0a4afb0dac0cdf1f8bc62de4eca..6d7a086926e041d447f96e9cb804b95ca45964b3 100644
--- a/webrtc/voice_engine/voe_base_impl.h
+++ b/webrtc/voice_engine/voe_base_impl.h
@@ -28,12 +28,15 @@ class VoEBaseImpl : public VoEBase,
int RegisterVoiceEngineObserver(VoiceEngineObserver& observer) override;
int DeRegisterVoiceEngineObserver() override;
- int Init(AudioDeviceModule* external_adm = nullptr,
- AudioProcessing* audioproc = nullptr,
- const rtc::scoped_refptr<AudioDecoderFactory>& decoder_factory =
- nullptr) override;
+ int Init(
+ AudioDeviceModule* external_adm,
+ AudioProcessing* external_apm,
+ const rtc::scoped_refptr<AudioDecoderFactory>& decoder_factory) override;
AudioProcessing* audio_processing() override {
- return shared_->audio_processing();
+ // TODO(peah): Remove this when downstream dependencies have properly been
+ // resolved.
+ RTC_DCHECK(audio_processing_);
+ return audio_processing_.get();
}
AudioDeviceModule* audio_device_module() override {
return shared_->audio_device();
@@ -121,6 +124,10 @@ class VoEBaseImpl : public VoEBase,
rtc::CriticalSection callbackCritSect_;
rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_;
+ // TODO(peah): Remove this when upstream dependencies have properly been
+ // resolved.
+ rtc::scoped_refptr<AudioProcessing> audio_processing_;
+
AudioFrame audioFrame_;
voe::SharedData* shared_;
};
« no previous file with comments | « webrtc/voice_engine/test/auto_test/standard/codec_test.cc ('k') | webrtc/voice_engine/voe_base_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698