Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: webrtc/sdk/objc/Framework/UnitTests/RTCTracingTest.mm

Issue 2961663002: Trace loggging: Check for g_event_logger is not null before calling it. (Closed)
Patch Set: Formatting. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/UnitTests/RTCTracingTest.mm
diff --git a/webrtc/sdk/objc/Framework/UnitTests/RTCTracingTest.mm b/webrtc/sdk/objc/Framework/UnitTests/RTCTracingTest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..6b328c61ad281f779e1b3c15779674c368f0a1d2
--- /dev/null
+++ b/webrtc/sdk/objc/Framework/UnitTests/RTCTracingTest.mm
@@ -0,0 +1,50 @@
+/*
+ * Copyright 2015 The WebRTC project authors. All Rights Reserved.
tommi 2017/07/07 08:53:50 the year should be 2017
jtt_webrtc 2017/07/07 16:22:40 Done.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#import <Foundation/Foundation.h>
+
+#include <vector>
+
+#include "webrtc/base/gunit.h"
+
+#import "NSString+StdString.h"
+#import "WebRTC/RTCTracing.h"
+
+@interface RTCTracingTest : NSObject
+- (void)tracingTestNoInitialization;
+@end
+
+@implementation RTCTracingTest
+
+- (NSString *)documentsFilePathForFileName:(NSString *)fileName {
+ NSParameterAssert(fileName.length);
+ NSArray *paths = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
+ NSString *documentsDirPath = paths.firstObject;
+ NSString *filePath =
+ [documentsDirPath stringByAppendingPathComponent:fileName];
+ return filePath;
+}
+
+- (void)tracingTestNoInitialization {
+ NSString *filePath = [self documentsFilePathForFileName:@"webrtc-trace.txt"];
+ EXPECT_EQ(NO, RTCStartInternalCapture(filePath));
+ RTCStopInternalCapture();
+}
+
+@end
+
+
+TEST(RTCTracingTest, TracingTestNoInitialization) {
+ @autoreleasepool {
+ RTCTracingTest *test = [[RTCTracingTest alloc] init];
+ [test tracingTestNoInitialization];
+ }
+}
+

Powered by Google App Engine
This is Rietveld 408576698