Trace loggging: Check for g_event_logger is not null before calling it.

webrtc/sdk/objc/Framework/UnitTests/RTCPeerConnectionTest.mm

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #import <Foundation/Foundation.h>
 
 #include <vector>
 
 #include "webrtc/base/gunit.h"
 
 #import "NSString+StdString.h"
 #import "RTCConfiguration+Private.h"
 #import "WebRTC/RTCConfiguration.h"
 #import "WebRTC/RTCPeerConnection.h"
 #import "WebRTC/RTCPeerConnectionFactory.h"
 #import "WebRTC/RTCIceServer.h"
 #import "WebRTC/RTCMediaConstraints.h"
+#import "WebRTC/RTCTracing.h"
 
 @interface RTCPeerConnectionTest : NSObject
 - (void)testConfigurationGetter;
+- (void)tracingTestNoInitialization;

[tkchin_webrtc, 2017/06/27 22:56:40]

This shouldn't belong in RTCPeerConnectionTest.
Write a new UT class/file for RTCTracing instead.

 @end
 
 @implementation RTCPeerConnectionTest
 
 - (void)testConfigurationGetter {
   NSArray *urlStrings = @[ @"stun:stun1.example.net" ];
   RTCIceServer *server = [[RTCIceServer alloc] initWithURLStrings:urlStrings];
 
   RTCConfiguration *config = [[RTCConfiguration alloc] init];
   config.iceServers = @[ server ];
@@ skipping 37 matching lines @@
   EXPECT_EQ(config.candidateNetworkPolicy, newConfig.candidateNetworkPolicy);
   EXPECT_EQ(config.audioJitterBufferMaxPackets, newConfig.audioJitterBufferMaxPackets);
   EXPECT_EQ(config.audioJitterBufferFastAccelerate, newConfig.audioJitterBufferFastAccelerate);
   EXPECT_EQ(config.iceConnectionReceivingTimeout, newConfig.iceConnectionReceivingTimeout);
   EXPECT_EQ(config.iceBackupCandidatePairPingInterval,
             newConfig.iceBackupCandidatePairPingInterval);
   EXPECT_EQ(config.continualGatheringPolicy, newConfig.continualGatheringPolicy);
   EXPECT_EQ(config.shouldPruneTurnPorts, newConfig.shouldPruneTurnPorts);
 }
 
+- (NSString *)documentsFilePathForFileName:(NSString *)fileName {
+  NSParameterAssert(fileName.length);
+  NSArray *paths = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
+  NSString *documentsDirPath = paths.firstObject;
+  NSString *filePath =
+  [documentsDirPath stringByAppendingPathComponent:fileName];
+  return filePath;
+}
+
+- (void)tracingTestNoInitialization {
+  NSString *filePath = [self documentsFilePathForFileName:@"webrtc-trace.txt"];
+  EXPECT_EQ(NO, RTCStartInternalCapture(filePath));
+  RTCStopInternalCapture();
+}
+
 @end
 
 TEST(RTCPeerConnectionTest, ConfigurationGetterTest) {
   @autoreleasepool {
     RTCPeerConnectionTest *test = [[RTCPeerConnectionTest alloc] init];
     [test testConfigurationGetter];
   }
 }
 
+TEST(RTCPeerConnectionTest, TracingTestNoInitialization) {
+  @autoreleasepool {
+    RTCPeerConnectionTest *test = [[RTCPeerConnectionTest alloc] init];
+    [test tracingTestNoInitialization];
+  }
+}