Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: ios/chrome/browser/sync/ios_user_event_service_factory.cc

Issue 2958303002: [Sync] Maintain a global_id mapping to update UserEvents that references navigations (Closed)
Patch Set: Rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/sync/ios_user_event_service_factory.cc
diff --git a/ios/chrome/browser/sync/ios_user_event_service_factory.cc b/ios/chrome/browser/sync/ios_user_event_service_factory.cc
index dcca1a85fd9193e850ab6be302988cfefd5ae667..f3b98bc125d7a911cbc1fab7b13f71cafdf69d0c 100644
--- a/ios/chrome/browser/sync/ios_user_event_service_factory.cc
+++ b/ios/chrome/browser/sync/ios_user_event_service_factory.cc
@@ -55,12 +55,14 @@ IOSUserEventServiceFactory::BuildServiceInstanceFor(
base::BindRepeating(&syncer::ModelTypeChangeProcessor::Create,
base::BindRepeating(&syncer::ReportUnrecoverableError,
::GetChannel()));
- auto bridge = base::MakeUnique<syncer::UserEventSyncBridge>(
- std::move(store_factory), std::move(processor_factory));
- return base::MakeUnique<syncer::UserEventServiceImpl>(
+ syncer::SyncService* sync_service =
IOSChromeProfileSyncServiceFactory::GetForBrowserState(
- ios::ChromeBrowserState::FromBrowserState(browser_state)),
- std::move(bridge));
+ ios::ChromeBrowserState::FromBrowserState(browser_state));
+ auto bridge = base::MakeUnique<syncer::UserEventSyncBridge>(
+ std::move(store_factory), std::move(processor_factory),
+ sync_service->GetGlobalIdMapper());
+ return base::MakeUnique<syncer::UserEventServiceImpl>(sync_service,
+ std::move(bridge));
}
web::BrowserState* IOSUserEventServiceFactory::GetBrowserStateToUse(

Powered by Google App Engine
This is Rietveld 408576698