Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2956553002: Retire JumpList favicon loading related UMA histograms (Closed)

Created:
3 years, 6 months ago by chengx
Modified:
3 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Retire JumpList favicon loading related UMA histograms This CL retires WinJumplist.OnFaviconDataAvailableDuration and WinJumplist.StartLoadingFaviconDuration as crbug/717236 is fixed and verified. BUG=717236 Review-Url: https://codereview.chromium.org/2956553002 Cr-Commit-Position: refs/heads/master@{#483467} Committed: https://chromium.googlesource.com/chromium/src/+/fad0f2a4cb07296a0293ccadb9be5e980a517e90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/browser/win/jumplist.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
chengx
PTAL, thanks!
3 years, 6 months ago (2017-06-23 00:24:27 UTC) #6
grt (UTC plus 2)
lgtm
3 years, 6 months ago (2017-06-23 09:37:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956553002/1
3 years, 6 months ago (2017-06-23 22:01:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/472789)
3 years, 6 months ago (2017-06-23 22:09:51 UTC) #13
Ilya Sherman
LGTM, thanks.
3 years, 5 months ago (2017-06-26 18:50:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956553002/1
3 years, 5 months ago (2017-06-29 17:54:08 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 20:20:56 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fad0f2a4cb07296a0293ccadb9be...

Powered by Google App Engine
This is Rietveld 408576698