Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: webrtc/call/rtp_demuxer.h

Issue 2955373002: Remove RtpDemuxer tweak for preventing multiple RSID inspections (Closed)
Patch Set: Fix test warning. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/call/rtp_demuxer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/rtp_demuxer.h
diff --git a/webrtc/call/rtp_demuxer.h b/webrtc/call/rtp_demuxer.h
index 5060a80a70806afe46213592f62d0f05c534bf7e..e557c4dbcc0ab3978708c3a62a3062932da29657 100644
--- a/webrtc/call/rtp_demuxer.h
+++ b/webrtc/call/rtp_demuxer.h
@@ -12,7 +12,6 @@
#define WEBRTC_CALL_RTP_DEMUXER_H_
#include <map>
-#include <set>
#include <string>
#include <vector>
@@ -60,9 +59,6 @@ class RtpDemuxer {
// packet reception.
void RecordSsrcToSinkAssociation(uint32_t ssrc, RtpPacketSinkInterface* sink);
- // When a new packet arrives, we attempt to resolve extra associations.
- void ResolveAssociations(const RtpPacketReceived& packet);
-
// Find the associations of RSID to SSRCs.
void ResolveRsidToSsrcAssociations(const RtpPacketReceived& packet);
@@ -79,15 +75,6 @@ class RtpDemuxer {
// from this container, and moved into |ssrc_sinks_|.
std::multimap<std::string, RtpPacketSinkInterface*> rsid_sinks_;
- // Iterating over |rsid_sinks_| for each incoming and performing multiple
- // string comparisons is of non-trivial cost. To avoid this cost, we only
- // check RSIDs for the first packet on each incoming SSRC stream.
- // (If RSID associations are added later, we check again.)
- std::set<uint32_t> processed_ssrcs_;
-
- // Avoid an attack that would create excessive logging.
- bool logged_max_processed_ssrcs_exceeded_ = false;
-
// Observers which will be notified when an RSID association to an SSRC is
// resolved by this object.
std::vector<RsidResolutionObserver*> rsid_resolution_observers_;
« no previous file with comments | « no previous file | webrtc/call/rtp_demuxer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698