Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2166)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

Issue 2954503002: Implement FrameMarking header extension support
Patch Set: Implement FrameMarking header extension and tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_utility.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
index 06786cb27afdb5b878645ad637c7d43d7af90bae..6f0f948aa3e191a867cae71abe64ac3555e21cca 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
@@ -253,6 +253,9 @@ bool RtpHeaderParser::Parse(RTPHeader* header,
header->extension.hasVideoContentType = false;
header->extension.videoContentType = VideoContentType::UNSPECIFIED;
+ // May not be present in packet.
+ header->extension.hasFrameMarks = false;
+
if (X) {
/* RTP header extension, RFC 3550.
0 1 2 3
@@ -473,6 +476,15 @@ void RtpHeaderParser::ParseOneByteExtensionHeader(
rtc::MakeArrayView(ptr, len + 1));
break;
}
+ case kRtpExtensionFrameMarking: {
+ if (!FrameMarking::Parse(rtc::MakeArrayView(ptr, len + 1),
+ &header->extension.frame_marks)) {
+ LOG(LS_WARNING) << "Incorrect frame marking extension";
+ return;
+ }
+ header->extension.hasFrameMarks = true;
+ break;
+ }
case kRtpExtensionNone:
case kRtpExtensionNumberOfExtensions: {
RTC_NOTREACHED() << "Invalid extension type: " << type;

Powered by Google App Engine
This is Rietveld 408576698