Implement FrameMarking header extension support

webrtc/common_types.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 680 matching lines @@
 // min = x, max = y indicates that the receiver is free to adapt
 // in the range (x, y) based on network jitter.
 //
 // Note: Given that this gets embedded in a union, it is up-to the owner to
 // initialize these values.
 struct PlayoutDelay {
   int min_ms;
   int max_ms;
 };
 
+// For Frame Marking RTP Header Extension:
+// https://tools.ietf.org/html/draft-ietf-avtext-framemarking-04#page-4
+// This extensions provides meta-information about the RTP streams outside the
+// encrypted media payload, an RTP switch can do codec-agnostic
+// selective forwarding without decrypting the payload
+//   o  S: Start of Frame (1 bit) - MUST be 1 in the first packet in a
+//      frame; otherwise MUST be 0.
+//   o  E: End of Frame (1 bit) - MUST be 1 in the last packet in a frame;
+//      otherwise MUST be 0.
+//   o  I: Independent Frame (1 bit) - MUST be 1 for frames that can be
+//      decoded independent of prior frames, e.g. intra-frame, VPX
+//      keyframe, H.264 IDR [RFC6184], H.265 IDR/CRA/BLA/RAP [RFC7798];
+//      otherwise MUST be 0.
+//   o  D: Discardable Frame (1 bit) - MUST be 1 for frames that can be
+//      discarded, and still provide a decodable media stream; otherwise
+//      MUST be 0.
+//   o  B: Base Layer Sync (1 bit) - MUST be 1 if this frame only depends
+//      on the base layer; otherwise MUST be 0.  If no scalability is
+//      used, this MUST be 0.
+//   o  TID: Temporal ID (3 bits) - The base temporal layer starts with 0,
+//      and increases with 1 for each higher temporal layer/sub-layer.  If
+//      no scalability is used, this MUST be 0.
+//   o  LID: Layer ID (8 bits) - Identifies the spatial and quality layer
+//      encoded.  If no scalability is used, this MUST be 0 or omitted.
+//      When omitted, TL0PICIDX MUST also be omitted.
+//   o  TL0PICIDX: Temporal Layer 0 Picture Index (8 bits) - Running index
+//      of base temporal layer 0 frames when TID is 0.  When TID is not 0,
+//      this indicates a dependency on the given index.  If no scalability
+//      is used, this MUST be 0 or omitted.  When omitted, LID MUST also
+//      be omitted.
+struct FrameMarks {
+  bool startOfFrame;

[danilchap, 2017/06/28 16:07:06]

use lowercase_with_underscores style for new code
https://google.github.io/styleguide/cppguide.html#Variable_Names

[sergio.garcia.murillo, 2017/06/29 12:58:57]

Done

+  bool endOfFrame;
+  bool independent;
+  bool discardable;
+  bool baseLayerSync;
+  uint8_t temporalLayerId;
+  uint8_t spatialLayerId;
+  uint8_t tl0PicIdx;
+};
+
 // Class to represent RtpStreamId which is a string.
 // Unlike std::string, it can be copied with memcpy and cleared with memset.
 // Empty value represent unset RtpStreamId.
 class StreamId {
  public:
   // Stream id is limited to 16 bytes because it is the maximum length
   // that can be encoded with one-byte header extensions.
   static constexpr size_t kMaxSize = 16;
 
   static bool IsLegalName(rtc::ArrayView<const char> name);
@@ skipping 52 matching lines @@
   bool hasVideoContentType;
   VideoContentType videoContentType;
 
   PlayoutDelay playout_delay = {-1, -1};
 
   // For identification of a stream when ssrc is not signaled. See
   // https://tools.ietf.org/html/draft-ietf-avtext-rid-09
   // TODO(danilchap): Update url from draft to release version.
   StreamId stream_id;
   StreamId repaired_stream_id;
+
+  // For Frame Marking RTP Header Extension:
+  // https://tools.ietf.org/html/draft-ietf-avtext-framemarking-04#page-4
+  bool hasFrameMarks;
+  FrameMarks frameMarks = { false, false, false, false, false, 0, 0, 0};
 };
 
 struct RTPHeader {
   RTPHeader();
 
   bool markerBit;
   uint8_t payloadType;
   uint16_t sequenceNumber;
   uint32_t timestamp;
   uint32_t ssrc;
@@ skipping 105 matching lines @@
 enum class RtcpMode { kOff, kCompound, kReducedSize };
 
 enum NetworkState {
   kNetworkUp,
   kNetworkDown,
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_COMMON_TYPES_H_