Expose ILBC codec in webrtc/api/audio_codecs/

webrtc/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/api/audio_codecs/audio_decoder_factory_template.h"
 #include "webrtc/api/audio_codecs/g722/audio_decoder_g722.h"
+#include "webrtc/api/audio_codecs/ilbc/audio_decoder_ilbc.h"
 #include "webrtc/base/ptr_util.h"
 #include "webrtc/test/gmock.h"
 #include "webrtc/test/gtest.h"
 #include "webrtc/test/mock_audio_decoder.h"
 
 namespace webrtc {
 
 namespace {
 
 struct BogusParams {
@@ skipping 101 matching lines @@
   EXPECT_EQ(16000, dec1->SampleRateHz());
   EXPECT_EQ(1u, dec1->Channels());
   auto dec2 = factory->MakeAudioDecoder({"g722", 8000, 2});
   ASSERT_NE(nullptr, dec2);
   EXPECT_EQ(16000, dec2->SampleRateHz());
   EXPECT_EQ(2u, dec2->Channels());
   auto dec3 = factory->MakeAudioDecoder({"g722", 8000, 3});
   ASSERT_EQ(nullptr, dec3);
 }
 
+TEST(AudioDecoderFactoryTemplateTest, Ilbc) {
+  auto factory = CreateAudioDecoderFactory<AudioDecoderIlbc>();
+  EXPECT_THAT(factory->GetSupportedDecoders(),
+              testing::ElementsAre(
+                  AudioCodecSpec{{"ILBC", 8000, 1}, {8000, 1, 13300}}));

[the sun, 2017/06/27 12:07:19]

What do you think about bitrate being 13300 here and 13333 in some other places?
IIUC the behavior is in the current code and just copied over here, though
there's the possibility that I've messed it up...

[kwiberg-webrtc, 2017/06/27 12:50:43]

I hadn't caught that, actually.

For the decoder, which doesn't know the frame length, this value seems made up.
I suspect it may just be an artifact of us using the same info struct type for
both encoders and decoders.

Anyway, keeping the existing value should be fine for this CL.

[ossu, 2017/06/27 12:53:14]

Hmm... acm_codec_database.cc claims that it's 13300 and that's the value used in
most places. I doubt it matters massively, but perhaps that value should be used
everywhere? Though 13333 is the more correct one.

I'd be fine with you leaving this as-is here and changing the values in a
separate CL. That one should be easy to revert in case something really depends
on these exact values.

+  EXPECT_FALSE(factory->IsSupportedDecoder({"foo", 8000, 1}));
+  EXPECT_TRUE(factory->IsSupportedDecoder({"ilbc", 8000, 1}));
+  EXPECT_EQ(nullptr, factory->MakeAudioDecoder({"bar", 8000, 1}));
+  auto dec = factory->MakeAudioDecoder({"ilbc", 8000, 1});
+  ASSERT_NE(nullptr, dec);
+  EXPECT_EQ(8000, dec->SampleRateHz());
+}
+
 }  // namespace webrtc