Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc

Issue 2947973002: Support moving pending requests from one DataUseRecorder to another (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
index 2604bdbcd8f1f71b7ed6ffe6b644ebab4c8f2ba2..48e011f60b5268ef4f952aaa45707b32729a72c0 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
@@ -125,7 +125,7 @@ TEST_F(ChromeDataUseAscriberTest, RenderFrameShownAndHidden) {
content::GlobalRequestID(kRenderProcessId, 0), kRenderProcessId,
kRenderFrameId);
ascriber()->DidFinishMainFrameNavigation(kRenderProcessId, kRenderFrameId,
- GURL("http://test.com"), true,
+ GURL("http://test.com"), false,
kPageTransition);
ascriber()->WasShownOrHidden(kRenderProcessId, kRenderFrameId, true);
@@ -148,7 +148,7 @@ TEST_F(ChromeDataUseAscriberTest, RenderFrameHiddenAndShown) {
content::GlobalRequestID(kRenderProcessId, 0), kRenderProcessId,
kRenderFrameId);
ascriber()->DidFinishMainFrameNavigation(kRenderProcessId, kRenderFrameId,
- GURL("http://test.com"), true,
+ GURL("http://test.com"), false,
kPageTransition);
ascriber()->WasShownOrHidden(kRenderProcessId, kRenderFrameId, false);
@@ -171,7 +171,7 @@ TEST_F(ChromeDataUseAscriberTest, RenderFrameHostChanged) {
content::GlobalRequestID(kRenderProcessId, 0), kRenderProcessId,
kRenderFrameId);
ascriber()->DidFinishMainFrameNavigation(kRenderProcessId, kRenderFrameId,
- GURL("http://test.com"), true,
+ GURL("http://test.com"), false,
kPageTransition);
ascriber()->WasShownOrHidden(kRenderProcessId, kRenderFrameId, true);
EXPECT_TRUE(ascriber()->GetDataUseRecorder(*request)->is_visible());
« no previous file with comments | « chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc ('k') | components/data_use_measurement/core/data_use.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698