Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate_unittest.cc

Issue 2947633003: Allow parsing empty RTCP TargetBitrate messages, but stop sending them. (Closed)
Patch Set: Add comment about using ToString only in tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate_unittest.cc
index 1c8f39de61d58541084f12346cf5a6b18d25f23f..2c5098d274018766f8bff673a6f26c662bb59e68 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate_unittest.cc
@@ -54,7 +54,7 @@ void CheckBitrateItems(const std::vector<BitrateItem>& bitrates) {
TEST(TargetBitrateTest, Parse) {
TargetBitrate target_bitrate;
- EXPECT_TRUE(target_bitrate.Parse(kPacket, kPacketLengthBlocks));
+ target_bitrate.Parse(kPacket, kPacketLengthBlocks);
CheckBitrateItems(target_bitrate.GetTargetBitrates());
}
@@ -86,4 +86,11 @@ TEST(TargetBitrateTest, Create) {
EXPECT_EQ(0, memcmp(kPacket, buffer, sizeof(kPacket)));
}
+TEST(TargetBitrateTest, ParseNullBitratePacket) {
+ const uint8_t kNullPacket[] = {TargetBitrate::kBlockType, 0x00, 0x00, 0x00};
+ TargetBitrate target_bitrate;
+ target_bitrate.Parse(kNullPacket, 0);
+ EXPECT_TRUE(target_bitrate.GetTargetBitrates().empty());
+}
+
} // namespace webrtc
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698