Allow parsing empty RTCP TargetBitrate messages, but stop sending them.

webrtc/common_types.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 613 matching lines @@
 
   uint32_t get_sum_bps() const { return sum_; }  // Sum of all bitrates.
   uint32_t get_sum_kbps() const { return (sum_ + 500) / 1000; }
 
   inline bool operator==(const BitrateAllocation& other) const {
     return memcmp(bitrates_, other.bitrates_, sizeof(bitrates_)) == 0;
   }
   inline bool operator!=(const BitrateAllocation& other) const {
     return !(*this == other);
   }
+  std::string ToString() const;
 
  private:
   uint32_t sum_;
   uint32_t bitrates_[kMaxSpatialLayers][kMaxTemporalStreams];
 };
 
+std::ostream& operator<<(std::ostream& os, const BitrateAllocation& bitrate);

[stefan-webrtc, 2017/06/22 11:10:38]

Where is this used? To me it seems like it should be in a test helper if we need
it only for testing? 

[sprang_webrtc, 2017/06/22 11:28:29]

It is not used, at the moment.
It is however something I use frequently when debugging, and I have grown tired
of constantly having to re-implement or patch this locally when that happens.
The operator<< is useful if you want to log it in a test, or just for getting an
immediate text representation inside a graphical debugger.
Where I exactly I've used it has varied. Sometime in the pacing module,
sometimes in the video coding module, sometimes in the rtp/rtcp module... so
having it in common types makes sense to me.

[stefan-webrtc, 2017/06/22 11:38:12]

Ok, I'm mostly worried about adding usage of stringstream, which I remember that
tommi has been trying to get rid of from webrtc since it's very heavy. That's
why I'd prefer to only build this into tests...

[sprang_webrtc, 2017/06/22 12:06:57]

Right.. I'll add a comment about about using this only in tests for now, perhaps
I can switch to something simpler after discussing with him?

+
 // Bandwidth over-use detector options.  These are used to drive
 // experimentation with bandwidth estimation parameters.
 // See modules/remote_bitrate_estimator/overuse_detector.h
 // TODO(terelius): This is only used in overuse_estimator.cc, and only in the
 // default constructed state. Can we move the relevant variables into that
 // class and delete this? See also disabled warning at line 27
 struct OverUseDetectorOptions {
   OverUseDetectorOptions()
       : initial_slope(8.0 / 512.0),
         initial_offset(0),
@@ skipping 238 matching lines @@
 enum class RtcpMode { kOff, kCompound, kReducedSize };
 
 enum NetworkState {
   kNetworkUp,
   kNetworkDown,
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_COMMON_TYPES_H_