Allow parsing empty RTCP TargetBitrate messages, but stop sending them.

webrtc/video/payload_router_unittest.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 160 matching lines @@
   BitrateAllocation layer1_bitrate;
   layer1_bitrate.SetBitrate(0, 0, 40000);
   layer1_bitrate.SetBitrate(0, 1, 80000);
 
   EXPECT_CALL(rtp_1, SetVideoBitrateAllocation(layer0_bitrate)).Times(1);
   EXPECT_CALL(rtp_2, SetVideoBitrateAllocation(layer1_bitrate)).Times(1);
 
   payload_router.OnBitrateAllocationUpdated(bitrate);
 }
 
+TEST(PayloadRouterTest, SimulcastTargetBitrateWithInactiveStream) {
+  NiceMock<MockRtpRtcp> rtp_1;
+  NiceMock<MockRtpRtcp> rtp_2;
+  std::vector<RtpRtcp*> modules;
+  modules.push_back(&rtp_1);
+  modules.push_back(&rtp_2);
+  PayloadRouter payload_router(modules, 42);
+  payload_router.SetActive(true);
+
+  BitrateAllocation bitrate;
+  bitrate.SetBitrate(0, 0, 10000);
+  bitrate.SetBitrate(0, 1, 20000);
+
+  BitrateAllocation layer0_bitrate;

[danilchap, 2017/06/20 10:29:27]

is it same as bitrate? why do you need two variables?

[sprang_webrtc, 2017/06/20 15:24:34]

I don't, I was just lazy (copy/paste from other test).
Fixed.

+  layer0_bitrate.SetBitrate(0, 0, 10000);
+  layer0_bitrate.SetBitrate(0, 1, 20000);
+
+  EXPECT_CALL(rtp_1, SetVideoBitrateAllocation(layer0_bitrate)).Times(1);
+  EXPECT_CALL(rtp_2, SetVideoBitrateAllocation(_)).Times(0);

[danilchap, 2017/06/20 10:29:26]

can you explain (with test name or comments, better both) why expectation are
like this?

[sprang_webrtc, 2017/06/20 15:24:34]

Done.

+
+  payload_router.OnBitrateAllocationUpdated(bitrate);
+}
+
 TEST(PayloadRouterTest, SvcTargetBitrate) {
   NiceMock<MockRtpRtcp> rtp_1;
   std::vector<RtpRtcp*> modules;
   modules.push_back(&rtp_1);
   PayloadRouter payload_router(modules, 42);
   payload_router.SetActive(true);
 
   BitrateAllocation bitrate;
   bitrate.SetBitrate(0, 0, 10000);
   bitrate.SetBitrate(0, 1, 20000);
   bitrate.SetBitrate(1, 0, 40000);
   bitrate.SetBitrate(1, 1, 80000);
 
   EXPECT_CALL(rtp_1, SetVideoBitrateAllocation(bitrate)).Times(1);
 
   payload_router.OnBitrateAllocationUpdated(bitrate);
 }
 
 }  // namespace webrtc