Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc

Issue 2947563002: Revert of Opus implementation of the AudioEncoderFactoryTemplate API (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc
diff --git a/webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc b/webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc
index aad413acfc97ba33530366f17237b4e2e58c50d9..b19991251b15b0014d238f622d05a869e7fc476b 100644
--- a/webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc
+++ b/webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc
@@ -19,10 +19,9 @@
namespace webrtc {
namespace {
-int64_t RunComplexityTest(const AudioEncoderOpusConfig& config) {
+int64_t RunComplexityTest(const AudioEncoderOpus::Config& config) {
// Create encoder.
- constexpr int payload_type = 17;
- AudioEncoderOpusImpl encoder(config, payload_type);
+ AudioEncoderOpus encoder(config);
// Open speech file.
const std::string kInputFileName =
webrtc::test::ResourcePath("audio_coding/speech_mono_32_48kHz", "pcm");
@@ -61,14 +60,14 @@
// the lower rate.
TEST(AudioEncoderOpusComplexityAdaptationTest, AdaptationOn) {
// Create config.
- AudioEncoderOpusConfig config;
+ AudioEncoderOpus::Config config;
// The limit -- including the hysteresis window -- at which the complexity
// shuold be increased.
- config.bitrate_bps = 11000 - 1;
+ config.bitrate_bps = rtc::Optional<int>(11000 - 1);
config.low_rate_complexity = 9;
int64_t runtime_10999bps = RunComplexityTest(config);
- config.bitrate_bps = 15500;
+ config.bitrate_bps = rtc::Optional<int>(15500);
int64_t runtime_15500bps = RunComplexityTest(config);
test::PrintResult("opus_encoding_complexity_ratio", "", "adaptation_on",
@@ -81,14 +80,14 @@
// that the resulting ratio is less than 100% at all times.
TEST(AudioEncoderOpusComplexityAdaptationTest, AdaptationOff) {
// Create config.
- AudioEncoderOpusConfig config;
+ AudioEncoderOpus::Config config;
// The limit -- including the hysteresis window -- at which the complexity
// shuold be increased (but not in this test since complexity adaptation is
// disabled).
- config.bitrate_bps = 11000 - 1;
+ config.bitrate_bps = rtc::Optional<int>(11000 - 1);
int64_t runtime_10999bps = RunComplexityTest(config);
- config.bitrate_bps = 15500;
+ config.bitrate_bps = rtc::Optional<int>(15500);
int64_t runtime_15500bps = RunComplexityTest(config);
test::PrintResult("opus_encoding_complexity_ratio", "", "adaptation_off",

Powered by Google App Engine
This is Rietveld 408576698