Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc

Issue 2947563002: Revert of Opus implementation of the AudioEncoderFactoryTemplate API (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/audio_codecs/test/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc
diff --git a/webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc b/webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc
index 4a7e291ed4a9949c07ba3ebb331a015c553df2de..abca96852badad56f2922b705455d0566a19c7ab 100644
--- a/webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc
+++ b/webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc
@@ -10,7 +10,6 @@
#include "webrtc/api/audio_codecs/audio_encoder_factory_template.h"
#include "webrtc/api/audio_codecs/g722/audio_encoder_g722.h"
-#include "webrtc/api/audio_codecs/opus/audio_encoder_opus.h"
#include "webrtc/base/ptr_util.h"
#include "webrtc/test/gmock.h"
#include "webrtc/test/gtest.h"
@@ -134,26 +133,4 @@
EXPECT_EQ(16000, enc->SampleRateHz());
}
-TEST(AudioEncoderFactoryTemplateTest, Opus) {
- auto factory = CreateAudioEncoderFactory<AudioEncoderOpus>();
- AudioCodecInfo info = {48000, 1, 32000, 6000, 510000};
- info.allow_comfort_noise = false;
- info.supports_network_adaption = true;
- EXPECT_THAT(
- factory->GetSupportedEncoders(),
- testing::ElementsAre(AudioCodecSpec{
- {"opus", 48000, 2, {{"minptime", "10"}, {"useinbandfec", "1"}}},
- info}));
- EXPECT_EQ(rtc::Optional<AudioCodecInfo>(),
- factory->QueryAudioEncoder({"foo", 8000, 1}));
- EXPECT_EQ(
- rtc::Optional<AudioCodecInfo>(info),
- factory->QueryAudioEncoder(
- {"opus", 48000, 2, {{"minptime", "10"}, {"useinbandfec", "1"}}}));
- EXPECT_EQ(nullptr, factory->MakeAudioEncoder(17, {"bar", 16000, 1}));
- auto enc = factory->MakeAudioEncoder(17, {"opus", 48000, 2});
- ASSERT_NE(nullptr, enc);
- EXPECT_EQ(48000, enc->SampleRateHz());
-}
-
} // namespace webrtc
« no previous file with comments | « webrtc/api/audio_codecs/test/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698