Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: webrtc/video/video_send_stream_tests.cc

Issue 2947133002: Fix timing frames and FEC conflict (Closed)
Patch Set: Fix typo Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream_tests.cc
diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc
index db1ba4f49014308a01b223958bce9b62db6f52ed..d759ed6ed66183c992d8eb021c232bf25d128057 100644
--- a/webrtc/video/video_send_stream_tests.cc
+++ b/webrtc/video/video_send_stream_tests.cc
@@ -296,9 +296,9 @@ TEST_F(VideoSendStreamTest, SupportsVideoRotation) {
}
TEST_F(VideoSendStreamTest, SupportsVideoContentType) {
- class VideoRotationObserver : public test::SendTest {
+ class VideoContentTypeObserver : public test::SendTest {
public:
- VideoRotationObserver() : SendTest(kDefaultTimeoutMs) {
+ VideoContentTypeObserver() : SendTest(kDefaultTimeoutMs) {
EXPECT_TRUE(parser_->RegisterRtpHeaderExtension(
kRtpExtensionVideoContentType, test::kVideoContentTypeExtensionId));
}
@@ -338,9 +338,9 @@ TEST_F(VideoSendStreamTest, SupportsVideoContentType) {
}
TEST_F(VideoSendStreamTest, SupportsVideoTimingFrames) {
- class VideoRotationObserver : public test::SendTest {
+ class VideoTimingObserver : public test::SendTest {
public:
- VideoRotationObserver() : SendTest(kDefaultTimeoutMs) {
+ VideoTimingObserver() : SendTest(kDefaultTimeoutMs) {
EXPECT_TRUE(parser_->RegisterRtpHeaderExtension(
kRtpExtensionVideoTiming, test::kVideoTimingExtensionId));
}
@@ -348,9 +348,11 @@ TEST_F(VideoSendStreamTest, SupportsVideoTimingFrames) {
Action OnSendRtp(const uint8_t* packet, size_t length) override {
RTPHeader header;
EXPECT_TRUE(parser_->Parse(packet, length, &header));
- if (header.extension.has_video_timing) {
- observation_complete_.Set();
- }
+ // Only the last packet of the frame must have extension.
+ if (!header.markerBit)
+ return SEND_PACKET;
+ EXPECT_TRUE(header.extension.has_video_timing);
+ observation_complete_.Set();
return SEND_PACKET;
}
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698