Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: webrtc/modules/video_coding/frame_buffer2.cc

Issue 2946413002: Report timing frames info in GetStats. (Closed)
Patch Set: Implement Deadbeef@ comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/frame_buffer2.cc
diff --git a/webrtc/modules/video_coding/frame_buffer2.cc b/webrtc/modules/video_coding/frame_buffer2.cc
index 1114e7cc0a42af0d2db66ce5f6cf07ac6419d031..e6c0d29d64001163b01d21624fda009895fbff55 100644
--- a/webrtc/modules/video_coding/frame_buffer2.cc
+++ b/webrtc/modules/video_coding/frame_buffer2.cc
@@ -149,6 +149,7 @@ FrameBuffer::ReturnReason FrameBuffer::NextFrame(
}
UpdateJitterDelay();
+ UpdateTimingFrameInfo();
PropagateDecodability(next_frame_it_->second);
// Sanity check for RTP timestamp monotonicity.
@@ -534,8 +535,15 @@ void FrameBuffer::UpdateJitterDelay() {
}
}
+void FrameBuffer::UpdateTimingFrameInfo() {
+ TRACE_EVENT0("webrtc", "FrameBuffer::UpdateTimingFrameInfo");
sprang_webrtc 2017/06/28 15:31:40 Do you a specific use case in mind for tracing thi
ilnik 2017/06/29 08:39:55 Well, we have tracing for |FrameBuffer::UpdateJitt
+ TimingFrameInfo info;
+ timing_->GetTimingFrameInfo(&info);
+ stats_callback_->OnTimingFrameInfoUpdated(info);
+}
+
void FrameBuffer::ClearFramesAndHistory() {
- TRACE_EVENT0("webrtc", "FrameBuffer::UpdateJitterDelay");
+ TRACE_EVENT0("webrtc", "FrameBuffer::ClearFramesAndHistory");
frames_.clear();
last_decoded_frame_it_ = frames_.end();
last_continuous_frame_it_ = frames_.end();

Powered by Google App Engine
This is Rietveld 408576698