Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: webrtc/video/receive_statistics_proxy.cc

Issue 2946413002: Report timing frames info in GetStats. (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/receive_statistics_proxy.cc
diff --git a/webrtc/video/receive_statistics_proxy.cc b/webrtc/video/receive_statistics_proxy.cc
index 2af19125c24ea62e8a5e5df136d5943744b4fc07..d0ac78b56e41410306a0d5e48983b66cbd9d1ece 100644
--- a/webrtc/video/receive_statistics_proxy.cc
+++ b/webrtc/video/receive_statistics_proxy.cc
@@ -406,6 +406,16 @@ VideoReceiveStream::Stats ReceiveStatisticsProxy::GetStats() const {
return stats_;
}
+rtc::Optional<TimingFrameInfo> ReceiveStatisticsProxy::GetTimingFrameInfo() {
sprang_webrtc 2017/07/06 09:13:08 nit: Rename this method so it's clear we're mutati
ilnik 2017/07/06 09:28:37 Done.
+ rtc::CritScope lock(&crit_);
+ rtc::Optional<TimingFrameInfo> info = timing_frame_info_;
+ // Reset reported value to empty, so it will be always
+ // overwritten in |OnTimingFrameInfoUpdated|, thus allowing to store new
+ // value instead of reported one.
+ timing_frame_info_.reset();
+ return info;
+}
+
void ReceiveStatisticsProxy::OnIncomingPayloadType(int payload_type) {
rtc::CritScope lock(&crit_);
stats_.current_payload_type = payload_type;
@@ -464,6 +474,17 @@ void ReceiveStatisticsProxy::OnFrameBufferTimingsUpdated(
"ssrc", stats_.ssrc);
}
+void ReceiveStatisticsProxy::OnTimingFrameInfoUpdated(
+ const TimingFrameInfo& info) {
+ rtc::CritScope lock(&crit_);
+ // Only the frame which was processed the longest since the last
+ // GetStats() call is reported. Therefore, only single 'longest' frame is
+ // stored.
+ if (!timing_frame_info_ || info.IsLongerThan(*timing_frame_info_)) {
+ timing_frame_info_.emplace(info);
+ }
+}
+
void ReceiveStatisticsProxy::RtcpPacketTypesCounterUpdated(
uint32_t ssrc,
const RtcpPacketTypeCounter& packet_counter) {

Powered by Google App Engine
This is Rietveld 408576698