Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: webrtc/api/video/video_timing.cc

Issue 2946413002: Report timing frames info in GetStats. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #ifndef WEBRTC_API_VIDEO_VIDEO_TIMING_CC_
12 #define WEBRTC_API_VIDEO_VIDEO_TIMING_CC_
13
14 #include "webrtc/api/video/video_timing.h"
15
16 #include <sstream>
17
Taylor Brandstetter 2017/06/25 20:48:03 nit: Extra newline
ilnik 2017/06/26 08:46:38 Done.
18
19 namespace webrtc {
20
21 TimingFrameInfo::TimingFrameInfo()
22 : rtp_timestamp(0),
23 capture_time_ms(-1),
24 encode_start_ms(-1),
25 encode_finish_ms(-1),
26 packetization_finish_ms(-1),
27 pacer_exit_ms(-1),
28 network_timestamp_ms(-1),
29 network2_timestamp_ms(-1),
30 receive_start_ms(-1),
31 receive_finish_ms(-1),
32 decode_start_ms(-1),
33 decode_finish_ms(-1),
34 render_time_ms(-1) {}
Taylor Brandstetter 2017/06/25 20:48:03 Can we use rtc::Optional instead of using -1 as a
ilnik 2017/06/26 08:46:38 Since some default values will have to be reported
Taylor Brandstetter 2017/06/27 07:01:38 That seems like an implementation detail of the To
ilnik 2017/06/27 15:23:56 Acknowledged.
35
36 int64_t TimingFrameInfo::EndToEndDelay() const {
37 return capture_time_ms >= 0 ? decode_finish_ms - capture_time_ms : -1;
38 }
39
40 bool TimingFrameInfo::IsLongerThan(const TimingFrameInfo& other) const {
41 int64_t other_delay = other.EndToEndDelay();
42 return other_delay == -1 || EndToEndDelay() > other_delay;
43 }
44
45 std::string TimingFrameInfo::ToString() const {
46 std::stringstream out;
47 out << rtp_timestamp << ',' << capture_time_ms << ',' << encode_start_ms
48 << ',' << encode_finish_ms << ',' << packetization_finish_ms << ','
49 << pacer_exit_ms << ',' << network_timestamp_ms << ','
50 << network2_timestamp_ms << ',' << receive_start_ms << ','
51 << receive_finish_ms << ',' << decode_start_ms << ','
52 << decode_finish_ms << ',' << render_time_ms;
53 return out.str();
54 }
55
56 } // namespace webrtc
57
58 #endif // WEBRTC_API_VIDEO_VIDEO_TIMING_CC_
59
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698