Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2944643002: Support building WebRTC without audio and video for IOS (Closed)
Patch Set: Add comments to BUILD.gn Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm » ('j') | webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 9526d60ce48b2df20cf784f10546b98c04c32b8e..e731f71a5c3237e77ca20880809806b095ee2713 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -102,15 +102,43 @@ if (is_ios || is_mac) {
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
+
+ # Create a separate target for video videotracksource related objects which would be used to
+ # build the PeerConnectionFactory without audio/video support.
tommi 2017/06/28 15:06:44 As the comment is currently written, I had some pr
Zhi Huang 2017/06/28 19:47:10 Your suggestion is better. Done.
+ rtc_static_library("objc_videotracksource") {
+ sources = [
+ "objc/Framework/Classes/Video/RTCCVPixelBuffer.mm",
+ "objc/Framework/Classes/Video/RTCI420Buffer+Private.h",
+ "objc/Framework/Classes/Video/RTCI420Buffer.mm",
+ "objc/Framework/Classes/Video/objc_frame_buffer.h",
+ "objc/Framework/Classes/Video/objc_frame_buffer.mm",
+ "objc/Framework/Classes/Video/objcvideotracksource.h",
+ "objc/Framework/Classes/Video/objcvideotracksource.mm",
+ "objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h",
+ ]
+
+ deps = [
+ ":objc_common",
+ "../api:libjingle_peerconnection_api",
+ "../api:video_frame_api",
+ "../base:rtc_base",
+ "../common_video",
+ "../media:rtc_media_base",
+ ]
+
+ configs += [ "..:common_objc" ]
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
tommi 2017/06/28 15:06:45 nit: keep shorter than 80 characters
Zhi Huang 2017/06/28 19:47:10 Done.
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
+ }
+
rtc_static_library("objc_video") {
sources = [
"objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.h",
"objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm",
- "objc/Framework/Classes/Video/RTCCVPixelBuffer.mm",
"objc/Framework/Classes/Video/RTCDefaultShader.h",
"objc/Framework/Classes/Video/RTCDefaultShader.mm",
- "objc/Framework/Classes/Video/RTCI420Buffer+Private.h",
- "objc/Framework/Classes/Video/RTCI420Buffer.mm",
"objc/Framework/Classes/Video/RTCI420TextureCache.h",
"objc/Framework/Classes/Video/RTCI420TextureCache.mm",
"objc/Framework/Classes/Video/RTCOpenGLDefines.h",
@@ -120,11 +148,6 @@ if (is_ios || is_mac) {
"objc/Framework/Classes/Video/avfoundationformatmapper.mm",
"objc/Framework/Classes/Video/avfoundationvideocapturer.h",
"objc/Framework/Classes/Video/avfoundationvideocapturer.mm",
- "objc/Framework/Classes/Video/objc_frame_buffer.h",
- "objc/Framework/Classes/Video/objc_frame_buffer.mm",
- "objc/Framework/Classes/Video/objcvideotracksource.h",
- "objc/Framework/Classes/Video/objcvideotracksource.mm",
- "objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h",
]
libs = []
if (is_ios) {
@@ -149,6 +172,7 @@ if (is_ios || is_mac) {
deps = [
":objc_common",
+ ":objc_videotracksource",
"../api:libjingle_peerconnection_api",
"../base:rtc_base",
"../common_video",
@@ -226,11 +250,112 @@ if (is_ios || is_mac) {
sources = [
"objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource+Private.h",
"objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource.mm",
+ "objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m",
+ "objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h",
+ ]
+ if (is_ios) {
+ sources += [
+ "objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.h",
+ "objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.m",
+ ]
+ }
+ libs = [ "AVFoundation.framework" ]
+
+ if (is_ios) {
+ libs += [ "CoreGraphics.framework" ]
+ }
+
+ configs += [ "..:common_objc" ]
+
+ public_configs = [ ":objc_common_config" ]
+
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
tommi 2017/06/28 15:06:44 <80
Zhi Huang 2017/06/28 19:47:10 Done.
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
+
+ deps = [
+ ":objc_common",
+ ":objc_corevideoframebuffer",
+ ":objc_peerconnectionfactory",
+ ":objc_video",
+ "../api:video_frame_api",
+ "../base:rtc_base",
+ "../media:rtc_media_base",
+ "../pc:libjingle_peerconnection",
+ ]
+
+ if (rtc_use_metal_rendering) {
+ deps += [ ":objc_metal" ]
+ }
+
+ if (rtc_build_libyuv) {
+ deps += [ "$rtc_libyuv_dir" ]
+ public_deps = [
+ "$rtc_libyuv_dir",
+ ]
+ }
+ }
+
+ rtc_static_library("objc_peerconnectionfactory") {
+ sources = [
+ "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Private.h",
+ "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm",
+ ]
+
+ public_configs = [ ":objc_common_config" ]
+
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
tommi 2017/06/28 15:06:45 <80
Zhi Huang 2017/06/28 19:47:10 Done.
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
+
+ deps = [
+ ":objc_common",
+ ":objc_corevideoframebuffer",
+ ":objc_peerconnectionfactory_base",
+ ":objc_video",
+ ":objc_videotoolbox",
+ "../api:video_frame_api",
+ "../base:rtc_base",
+ "../media:rtc_media_base",
+ "../pc:create_pc_factory",
+ "../pc:peerconnection",
+ ]
+ }
+
+ # Build the PeerConnectionFactory without audio/video support. This target depends on the
tommi 2017/06/28 15:06:44 <80 (here is a good example of how it's easier to
+ # objc_peeerconnectionfactory_base which still includes some audio/video related objects such as
+ # RTCAudioSource because these objects are just thin wrappers of native C++ interfaces required
+ # when implementing webrtc::PeerConnectionFactoryInterface and webrtc::PeerConnectionInterface.
+ rtc_static_library("objc_peerconnectionfactory_no_media") {
+ defines = [ "HAVE_NO_MEDIA" ]
+
+ sources = [
+ "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Private.h",
+ "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm",
+ ]
+
+ public_configs = [ ":objc_common_config" ]
+
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
tommi 2017/06/28 15:06:44 ditto
Zhi Huang 2017/06/28 19:47:10 Done.
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
+
+ deps = [
+ ":objc_peerconnectionfactory_base",
+ "../api:libjingle_peerconnection_api",
+ "../base:rtc_base",
+ ]
+ }
+
+ rtc_static_library("objc_peerconnectionfactory_base") {
+ sources = [
"objc/Framework/Classes/PeerConnection/RTCAudioSource+Private.h",
"objc/Framework/Classes/PeerConnection/RTCAudioSource.mm",
"objc/Framework/Classes/PeerConnection/RTCAudioTrack+Private.h",
"objc/Framework/Classes/PeerConnection/RTCAudioTrack.mm",
- "objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m",
"objc/Framework/Classes/PeerConnection/RTCConfiguration+Private.h",
"objc/Framework/Classes/PeerConnection/RTCConfiguration.mm",
"objc/Framework/Classes/PeerConnection/RTCDataChannel+Private.h",
@@ -258,8 +383,6 @@ if (is_ios || is_mac) {
"objc/Framework/Classes/PeerConnection/RTCPeerConnection+Private.h",
"objc/Framework/Classes/PeerConnection/RTCPeerConnection+Stats.mm",
"objc/Framework/Classes/PeerConnection/RTCPeerConnection.mm",
- "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Private.h",
- "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm",
"objc/Framework/Classes/PeerConnection/RTCRtpCodecParameters+Private.h",
"objc/Framework/Classes/PeerConnection/RTCRtpCodecParameters.mm",
"objc/Framework/Classes/PeerConnection/RTCRtpEncodingParameters+Private.h",
@@ -286,7 +409,6 @@ if (is_ios || is_mac) {
"objc/Framework/Headers/WebRTC/RTCAVFoundationVideoSource.h",
"objc/Framework/Headers/WebRTC/RTCAudioSource.h",
"objc/Framework/Headers/WebRTC/RTCAudioTrack.h",
- "objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h",
"objc/Framework/Headers/WebRTC/RTCConfiguration.h",
"objc/Framework/Headers/WebRTC/RTCDataChannel.h",
"objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h",
@@ -317,17 +439,6 @@ if (is_ios || is_mac) {
"objc/Framework/Headers/WebRTC/RTCVideoTrack.h",
"objc/Framework/Headers/WebRTC/RTCVideoViewShading.h",
]
- if (is_ios) {
- sources += [
- "objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.h",
- "objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.m",
- ]
- }
- libs = [ "AVFoundation.framework" ]
-
- if (is_ios) {
- libs += [ "CoreGraphics.framework" ]
- }
configs += [ "..:common_objc" ]
@@ -341,25 +452,13 @@ if (is_ios || is_mac) {
deps = [
":objc_common",
":objc_corevideoframebuffer",
- ":objc_video",
- ":objc_videotoolbox",
+ ":objc_videotracksource",
"../api:video_frame_api",
"../base:rtc_base",
"../common_video",
"../media:rtc_media_base",
- "../pc:libjingle_peerconnection",
+ "../pc:peerconnection",
]
-
- if (rtc_use_metal_rendering) {
- deps += [ ":objc_metal" ]
- }
-
- if (rtc_build_libyuv) {
- deps += [ "$rtc_libyuv_dir" ]
- public_deps = [
- "$rtc_libyuv_dir",
- ]
- }
}
if (rtc_include_tests) {
@@ -567,6 +666,7 @@ if (is_ios || is_mac) {
deps = [
":objc_common",
":objc_video",
+ ":objc_videotracksource",
"../base:rtc_base_approved",
"../common_video",
"../media:rtc_media",
« no previous file with comments | « no previous file | webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm » ('j') | webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698