Support building WebRTC without audio and video for IOS

webrtc/sdk/BUILD.gn

 # Copyright 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 if (is_ios) {
@@ skipping 84 matching lines @@
       deps = [
         ":objc_common",
         "../base:rtc_base_approved",
       ]
 
       if (is_clang) {
         # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
         suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
       }
     }
+
+    # Create a separate target for video videotracksource related objects which would be used to
+    # build the PeerConnectionFactory without audio/video support.

[tommi, 2017/06/28 15:06:44]

As the comment is currently written, I had some problems parsing it.  What
about:

# Keep videotracksource related code in a separate target so that we can build
# PeerConnectionFactory without audio/video support when that's called for.

Also, I think it would be nice if we could keep comment lines limited to 80
columns to make them more readable in code reviews.

[Zhi Huang, 2017/06/28 19:47:10]

Your suggestion is better. 
Done.

+    rtc_static_library("objc_videotracksource") {
+      sources = [
+        "objc/Framework/Classes/Video/RTCCVPixelBuffer.mm",
+        "objc/Framework/Classes/Video/RTCI420Buffer+Private.h",
+        "objc/Framework/Classes/Video/RTCI420Buffer.mm",
+        "objc/Framework/Classes/Video/objc_frame_buffer.h",
+        "objc/Framework/Classes/Video/objc_frame_buffer.mm",
+        "objc/Framework/Classes/Video/objcvideotracksource.h",
+        "objc/Framework/Classes/Video/objcvideotracksource.mm",
+        "objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h",
+      ]
+
+      deps = [
+        ":objc_common",
+        "../api:libjingle_peerconnection_api",
+        "../api:video_frame_api",
+        "../base:rtc_base",
+        "../common_video",
+        "../media:rtc_media_base",
+      ]
+
+      configs += [ "..:common_objc" ]
+      if (!build_with_chromium && is_clang) {
+        # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).

[tommi, 2017/06/28 15:06:45]

nit: keep shorter than 80 characters

[Zhi Huang, 2017/06/28 19:47:10]

Done.

+        suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+      }
+    }
+
     rtc_static_library("objc_video") {
       sources = [
         "objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.h",
         "objc/Framework/Classes/Video/RTCAVFoundationVideoCapturerInternal.mm",
-        "objc/Framework/Classes/Video/RTCCVPixelBuffer.mm",
         "objc/Framework/Classes/Video/RTCDefaultShader.h",
         "objc/Framework/Classes/Video/RTCDefaultShader.mm",
-        "objc/Framework/Classes/Video/RTCI420Buffer+Private.h",
-        "objc/Framework/Classes/Video/RTCI420Buffer.mm",
         "objc/Framework/Classes/Video/RTCI420TextureCache.h",
         "objc/Framework/Classes/Video/RTCI420TextureCache.mm",
         "objc/Framework/Classes/Video/RTCOpenGLDefines.h",
         "objc/Framework/Classes/Video/RTCShader.h",
         "objc/Framework/Classes/Video/RTCShader.mm",
         "objc/Framework/Classes/Video/avfoundationformatmapper.h",
         "objc/Framework/Classes/Video/avfoundationformatmapper.mm",
         "objc/Framework/Classes/Video/avfoundationvideocapturer.h",
         "objc/Framework/Classes/Video/avfoundationvideocapturer.mm",
-        "objc/Framework/Classes/Video/objc_frame_buffer.h",
-        "objc/Framework/Classes/Video/objc_frame_buffer.mm",
-        "objc/Framework/Classes/Video/objcvideotracksource.h",
-        "objc/Framework/Classes/Video/objcvideotracksource.mm",
-        "objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h",
       ]
       libs = []
       if (is_ios) {
         sources += [
           "objc/Framework/Classes/Video/RTCNV12TextureCache.h",
           "objc/Framework/Classes/Video/RTCNV12TextureCache.m",
         ]
         libs += [
           "GLKit.framework",
           "OpenGLES.framework",
           "QuartzCore.framework",
         ]
       } else if (is_mac) {
         sources += []
 
         libs += [
           "CoreMedia.framework",
           "CoreVideo.framework",
           "OpenGL.framework",
         ]
       }
 
       deps = [
         ":objc_common",
+        ":objc_videotracksource",
         "../api:libjingle_peerconnection_api",
         "../base:rtc_base",
         "../common_video",
         "../media:rtc_media_base",
       ]
 
       configs += [ "..:common_objc" ]
       if (!build_with_chromium && is_clang) {
         # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
         suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ skipping 57 matching lines @@
         ]
         configs += [ "..:common_objc" ]
         public_configs = [ ":objc_common_config" ]
       }
     }
 
     rtc_static_library("objc_peerconnection") {
       sources = [
         "objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource.mm",
+        "objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m",
+        "objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h",
+      ]
+      if (is_ios) {
+        sources += [
+          "objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.h",
+          "objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.m",
+        ]
+      }
+      libs = [ "AVFoundation.framework" ]
+
+      if (is_ios) {
+        libs += [ "CoreGraphics.framework" ]
+      }
+
+      configs += [ "..:common_objc" ]
+
+      public_configs = [ ":objc_common_config" ]
+
+      if (!build_with_chromium && is_clang) {
+        # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).

[tommi, 2017/06/28 15:06:44]

<80

[Zhi Huang, 2017/06/28 19:47:10]

Done.

+        suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+      }
+
+      deps = [
+        ":objc_common",
+        ":objc_corevideoframebuffer",
+        ":objc_peerconnectionfactory",
+        ":objc_video",
+        "../api:video_frame_api",
+        "../base:rtc_base",
+        "../media:rtc_media_base",
+        "../pc:libjingle_peerconnection",
+      ]
+
+      if (rtc_use_metal_rendering) {
+        deps += [ ":objc_metal" ]
+      }
+
+      if (rtc_build_libyuv) {
+        deps += [ "$rtc_libyuv_dir" ]
+        public_deps = [
+          "$rtc_libyuv_dir",
+        ]
+      }
+    }
+
+    rtc_static_library("objc_peerconnectionfactory") {
+      sources = [
+        "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Private.h",
+        "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm",
+      ]
+
+      public_configs = [ ":objc_common_config" ]
+
+      if (!build_with_chromium && is_clang) {
+        # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).

[tommi, 2017/06/28 15:06:45]

<80

[Zhi Huang, 2017/06/28 19:47:10]

Done.

+        suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+      }
+
+      deps = [
+        ":objc_common",
+        ":objc_corevideoframebuffer",
+        ":objc_peerconnectionfactory_base",
+        ":objc_video",
+        ":objc_videotoolbox",
+        "../api:video_frame_api",
+        "../base:rtc_base",
+        "../media:rtc_media_base",
+        "../pc:create_pc_factory",
+        "../pc:peerconnection",
+      ]
+    }
+
+    # Build the PeerConnectionFactory without audio/video support. This target depends on the

[tommi, 2017/06/28 15:06:44]

<80
(here is a good example of how it's easier to read the comment if we wrap at 80)

+    # objc_peeerconnectionfactory_base which still includes some audio/video related objects such as
+    # RTCAudioSource because these objects are just thin wrappers of native C++ interfaces required
+    # when implementing webrtc::PeerConnectionFactoryInterface and webrtc::PeerConnectionInterface.
+    rtc_static_library("objc_peerconnectionfactory_no_media") {
+      defines = [ "HAVE_NO_MEDIA" ]
+
+      sources = [
+        "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Private.h",
+        "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm",
+      ]
+
+      public_configs = [ ":objc_common_config" ]
+
+      if (!build_with_chromium && is_clang) {
+        # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).

[tommi, 2017/06/28 15:06:44]

ditto

[Zhi Huang, 2017/06/28 19:47:10]

Done.

+        suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+      }
+
+      deps = [
+        ":objc_peerconnectionfactory_base",
+        "../api:libjingle_peerconnection_api",
+        "../base:rtc_base",
+      ]
+    }
+
+    rtc_static_library("objc_peerconnectionfactory_base") {
+      sources = [
         "objc/Framework/Classes/PeerConnection/RTCAudioSource+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCAudioSource.mm",
         "objc/Framework/Classes/PeerConnection/RTCAudioTrack+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCAudioTrack.mm",
-        "objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m",
         "objc/Framework/Classes/PeerConnection/RTCConfiguration+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCConfiguration.mm",
         "objc/Framework/Classes/PeerConnection/RTCDataChannel+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCDataChannel.mm",
         "objc/Framework/Classes/PeerConnection/RTCDataChannelConfiguration+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCDataChannelConfiguration.mm",
         "objc/Framework/Classes/PeerConnection/RTCIceCandidate+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCIceCandidate.mm",
         "objc/Framework/Classes/PeerConnection/RTCIceServer+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCIceServer.mm",
         "objc/Framework/Classes/PeerConnection/RTCLegacyStatsReport+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCLegacyStatsReport.mm",
         "objc/Framework/Classes/PeerConnection/RTCMediaConstraints+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCMediaConstraints.mm",
         "objc/Framework/Classes/PeerConnection/RTCMediaSource+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCMediaSource.mm",
         "objc/Framework/Classes/PeerConnection/RTCMediaStream+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCMediaStream.mm",
         "objc/Framework/Classes/PeerConnection/RTCMediaStreamTrack+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCMediaStreamTrack.mm",
         "objc/Framework/Classes/PeerConnection/RTCMetrics.mm",
         "objc/Framework/Classes/PeerConnection/RTCMetricsSampleInfo+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCMetricsSampleInfo.mm",
         "objc/Framework/Classes/PeerConnection/RTCPeerConnection+DataChannel.mm",
         "objc/Framework/Classes/PeerConnection/RTCPeerConnection+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCPeerConnection+Stats.mm",
         "objc/Framework/Classes/PeerConnection/RTCPeerConnection.mm",
-        "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Private.h",
-        "objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm",
         "objc/Framework/Classes/PeerConnection/RTCRtpCodecParameters+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCRtpCodecParameters.mm",
         "objc/Framework/Classes/PeerConnection/RTCRtpEncodingParameters+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCRtpEncodingParameters.mm",
         "objc/Framework/Classes/PeerConnection/RTCRtpParameters+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCRtpParameters.mm",
         "objc/Framework/Classes/PeerConnection/RTCRtpReceiver+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCRtpReceiver.mm",
         "objc/Framework/Classes/PeerConnection/RTCRtpSender+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCRtpSender.mm",
         "objc/Framework/Classes/PeerConnection/RTCSSLAdapter.mm",
         "objc/Framework/Classes/PeerConnection/RTCSessionDescription+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCSessionDescription.mm",
         "objc/Framework/Classes/PeerConnection/RTCTracing.mm",
         "objc/Framework/Classes/PeerConnection/RTCVideoCapturer.m",
         "objc/Framework/Classes/PeerConnection/RTCVideoFrame.mm",
         "objc/Framework/Classes/PeerConnection/RTCVideoRendererAdapter+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCVideoRendererAdapter.h",
         "objc/Framework/Classes/PeerConnection/RTCVideoRendererAdapter.mm",
         "objc/Framework/Classes/PeerConnection/RTCVideoSource+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCVideoSource.mm",
         "objc/Framework/Classes/PeerConnection/RTCVideoTrack+Private.h",
         "objc/Framework/Classes/PeerConnection/RTCVideoTrack.mm",
         "objc/Framework/Headers/WebRTC/RTCAVFoundationVideoSource.h",
         "objc/Framework/Headers/WebRTC/RTCAudioSource.h",
         "objc/Framework/Headers/WebRTC/RTCAudioTrack.h",
-        "objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h",
         "objc/Framework/Headers/WebRTC/RTCConfiguration.h",
         "objc/Framework/Headers/WebRTC/RTCDataChannel.h",
         "objc/Framework/Headers/WebRTC/RTCDataChannelConfiguration.h",
         "objc/Framework/Headers/WebRTC/RTCIceCandidate.h",
         "objc/Framework/Headers/WebRTC/RTCIceServer.h",
         "objc/Framework/Headers/WebRTC/RTCLegacyStatsReport.h",
         "objc/Framework/Headers/WebRTC/RTCMediaConstraints.h",
         "objc/Framework/Headers/WebRTC/RTCMediaSource.h",
         "objc/Framework/Headers/WebRTC/RTCMediaStream.h",
         "objc/Framework/Headers/WebRTC/RTCMediaStreamTrack.h",
@@ skipping 10 matching lines @@
         "objc/Framework/Headers/WebRTC/RTCSessionDescription.h",
         "objc/Framework/Headers/WebRTC/RTCTracing.h",
         "objc/Framework/Headers/WebRTC/RTCVideoCapturer.h",
         "objc/Framework/Headers/WebRTC/RTCVideoFrame.h",
         "objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h",
         "objc/Framework/Headers/WebRTC/RTCVideoRenderer.h",
         "objc/Framework/Headers/WebRTC/RTCVideoSource.h",
         "objc/Framework/Headers/WebRTC/RTCVideoTrack.h",
         "objc/Framework/Headers/WebRTC/RTCVideoViewShading.h",
       ]
-      if (is_ios) {
-        sources += [
-          "objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.h",
-          "objc/Framework/Classes/PeerConnection/RTCFileVideoCapturer.m",
-        ]
-      }
-      libs = [ "AVFoundation.framework" ]
-
-      if (is_ios) {
-        libs += [ "CoreGraphics.framework" ]
-      }
 
       configs += [ "..:common_objc" ]
 
       public_configs = [ ":objc_common_config" ]
 
       if (!build_with_chromium && is_clang) {
         # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
         suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
       }
 
       deps = [
         ":objc_common",
         ":objc_corevideoframebuffer",
-        ":objc_video",
-        ":objc_videotoolbox",
+        ":objc_videotracksource",
         "../api:video_frame_api",
         "../base:rtc_base",
         "../common_video",
         "../media:rtc_media_base",
-        "../pc:libjingle_peerconnection",
+        "../pc:peerconnection",
       ]
-
-      if (rtc_use_metal_rendering) {
-        deps += [ ":objc_metal" ]
-      }
-
-      if (rtc_build_libyuv) {
-        deps += [ "$rtc_libyuv_dir" ]
-        public_deps = [
-          "$rtc_libyuv_dir",
-        ]
-      }
     }
 
     if (rtc_include_tests) {
       rtc_source_set("objc_sdk_unittests") {
         testonly = true
 
         # Skip restricting visibility on mobile platforms since the tests on those
         # gets additional generated targets which would require many lines here to
         # cover (which would be confusing to read and hard to maintain).
         if (!is_android && !is_ios) {
@@ skipping 187 matching lines @@
         "objc/Framework/Classes/VideoToolbox/videocodecfactory.h",
         "objc/Framework/Classes/VideoToolbox/videocodecfactory.mm",
         "objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h",
       ]
 
       configs += [ "..:common_objc" ]
 
       deps = [
         ":objc_common",
         ":objc_video",
+        ":objc_videotracksource",
         "../base:rtc_base_approved",
         "../common_video",
         "../media:rtc_media",
         "../media:rtc_media_base",
         "../modules:module_api",
         "../modules/video_coding:video_coding_utility",
         "../modules/video_coding:webrtc_h264",
         "../system_wrappers",
       ]
 
@@ skipping 14 matching lines @@
         public_deps = [
           "$rtc_libyuv_dir",
         ]
       } else {
         # Need to add a directory normally exported by libyuv.
         include_dirs = [ "$rtc_libyuv_dir/include" ]
       }
     }
   }
 }